chore: upgrade vitest #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-boris
commented
Nov 18, 2022
src/internal/grid/grid.test.tsx
Outdated
| @@ -3,7 +3,7 @@ | |||
| import { render } from "@testing-library/react"; | |||
| import { expect, test } from "vitest"; | |||
| import Grid, { GridProps } from "../../../lib/components/internal/grid"; | |||
| import gridStyles from "../../../lib/components/internal/grid/styles.selectors.js"; | |||
| import gridStyles from "../../../lib/components/internal/grid/styles.css.js"; | |||
There was a problem hiding this comment.
.selectors.js contain commonjs code, .css.js contains esm. Without this change, gridStyles becomes: { default: {...classes...} } and does not work
just-boris
force-pushed
the
upgrade
branch
4 times, most recently
from
52d92e7
to
c257196
Compare
just-boris
requested review from
rubencarvalho
and removed request for
a team
just-boris
commented
Nov 18, 2022
rubencarvalho
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An addition to #46. Putting vitest in a separate PR, because there are some breaking changes needed manual changes.
Related change in vitest: vitest-dev/vitest#2226. Their new behavior is more correct, because it is closer how node.js handles the same esm-commonjs imports
How has this been tested?
PR build, local
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.