feat: Add keyboard accessibility to fold controls in code editor #1105
Conversation
avinashbot
force-pushed
the
ace-gutter-a11y
branch
from
1893525
to
492895e
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1105 +/- ##
==========================================
+ Coverage 93.20% 93.22% +0.02%
==========================================
Files 617 620 +3
Lines 16386 16464 +78
Branches 5366 5391 +25
==========================================
+ Hits 15272 15349 +77
- Misses 1041 1042 +1
Partials 73 73
☔ View full report in Codecov by Sentry. |
avinashbot
force-pushed
the
ace-gutter-a11y
branch
from
492895e
to
e5afe0b
Compare
avinashbot
force-pushed
the
ace-gutter-a11y
branch
from
4eb81ea
to
e250caf
Compare
avinashbot
force-pushed
the
ace-gutter-a11y
branch
from
41de288
to
9819de9
Compare
avinashbot
force-pushed
the
ace-gutter-a11y
branch
from
6370f48
to
6e6673d
Compare
| ace.config.set('themePath', './ace/'); | ||
| ace.config.set('modePath', './ace/'); | ||
| ace.config.set('workerPath', './ace/'); |
There was a problem hiding this comment.
is a dry run to live necessary here to make sure that there isn't customers who depends on this?
There was a problem hiding this comment.
Good reminder, will do! This is an ace minor version bump and the version provided to us is dependent on the developer, so it's technically backwards compatible. But with us bumping our (technically type-only) ace-builds dependency, it might get npm to resolve the whole application to the greater ace-builds version.
There was a problem hiding this comment.
Approved, feel free to merge after running the dry run
There was a problem hiding this comment.
Tested it, no issues other than the known one unrelated to this PR.
Description
Ace recently released a flag to allow keyboard access to the gutter and code folding controls, and just improve keyboard accessibility in general (ajaxorg/ace#5146). This PR enables that option, and integrates it with the pane. Additionally, it simplifies the pane's focus management logic.
There are some changes around ace-builds 1.15.0 that breaks/changes how basePath is set, so I had to mess with the ace config in the dev pages, but following up on that shouldn't block this release. We use "ace-builds" in the component itself for the typings alone.
Related links, issue #, if available: AWSUI-19227
How has this been tested?
Tests have been changed where they were failing due to behavioral changes. The rest is visual.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.