Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Report bundle size for every commit in main #2266

Merged
merged 1 commit into from
May 21, 2024

Conversation

jperals
Copy link
Member

@jperals jperals commented May 17, 2024

Description

  • Report bundle size on push (not just on pull request). This is so that reports can be associated with commits.
  • Extend bundle size report to include dependency versions taken from packagelock.json, as @cloudscape-design dependencies are not pinned in package.json

How has this been tested?

See:

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.39%. Comparing base (536f5f4) to head (06d0939).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2266      +/-   ##
==========================================
- Coverage   95.40%   95.39%   -0.01%     
==========================================
  Files         705      705              
  Lines       18715    18715              
  Branches     6222     5944     -278     
==========================================
- Hits        17855    17854       -1     
- Misses        807      854      +47     
+ Partials       53        7      -46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -26,7 +26,7 @@ function getStatusMetadata(context) {
return {
owner: context.repo.owner,
repo: context.repo.repo,
sha: context.payload.pull_request.head.sha,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use sha directly from the context: https://github.com/actions/toolkit/blob/main/packages/github/src/context.ts#L13

This allows it to work both for pushes and for pull requests.

@jperals jperals marked this pull request as ready for review May 17, 2024 14:07
@jperals jperals requested a review from a team as a code owner May 17, 2024 14:07
@jperals jperals requested review from abdhalees and removed request for a team May 17, 2024 14:07
@jperals jperals requested a review from just-boris May 21, 2024 06:59
@jperals jperals merged commit 41a606f into main May 21, 2024
35 checks passed
@jperals jperals deleted the feat/bundle-size-report-main branch May 21, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants