[WIP] Lots of changes towards more SIP compliance #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better concurrency
RFC3261 says it is optional, but almost none of the implementations add it. So leaving it out is better for compatibility.
Introduce a new status: TimedOut
Don't error out on already terminated session. No harm is done.
SetState() is also called in handleInviteState() called directly below
handleInviteState does it again
The handleInviteState with status = EarlyMedia is only called directly after the same call with the same response, only with status = Provisional. As the respons is identical, no need to store again.
As RFC3261 says the route-set can't change during a dialog, the route-set is only stored for initial INVITE and its responses. The route-set is added as Route header to all in-dialog requests.
Tracking and checking the remote CSeq beyond the initial INVITE is not yet implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still not finished.
Please comment if this is the correct direction.
Some API's have changed. Examples have not been adjusted to the changes.
Next would be to eliminate StoreResponse/StoreRequest. These are getting in the way.