Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix docker example in quick_start.md #1066

Merged
merged 2 commits into from
May 6, 2024
Merged

docs: fix docker example in quick_start.md #1066

merged 2 commits into from
May 6, 2024

Conversation

ShawnJeffersonWang
Copy link
Contributor

No description provided.

@ShawnJeffersonWang ShawnJeffersonWang requested review from a team as code owners April 30, 2024 04:07
@vercel Vercel
Copy link

vercel bot commented Apr 30, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cloudwego ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 5:49am

@CLAassistant
Copy link

CLAassistant commented Apr 30, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@li-jin-gou
Copy link
Member

cla need to sign @ShawnJeffersonWang

@ShawnJeffersonWang
Copy link
Contributor Author

cla need to sign @ShawnJeffersonWang

got it

GuangmingLuo
GuangmingLuo approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@GuangmingLuo GuangmingLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@GuangmingLuo GuangmingLuo merged commit 8488f13 into cloudwego:main May 6, 2024
3 checks passed
@L33Z22L11
Copy link

@ShawnJeffersonWang 今天下午向我咨询了关于 Markdown 被“意外地”格式化的问题。经过检查，我认为原因如下：

  • build: format docs in pre-commit #681 为这个仓库的中文文档提供了格式化能力。
  • Shawn 在 commit 时触发了 .git/hooks/pre-commit 钩子函数。
  • 钩子函数运行了 npm run format，导致文档格式化。

我认为，将 * 修改为 - 是符合预期的、提升文档规范性的行为，不需要刻意避免，而且难以避免，因为任何新的 commit 都有可能导致 content/en/docs/hertz/tutorials/basic-feature/binding-and-validate.md 被修改为更规范的格式。

@GuangmingLuo
Copy link
Member

@L33Z22L11 感谢反馈。为了让每个 PR 更加聚焦自己要解决的问题， @rogerogers 提交了个 PR 统一优化了格式 #1069

@li-jin-gou
Copy link
Member

li-jin-gou commented May 8, 2024 •
edited

@L33Z22L11 感谢反馈。为了让每个 PR 更加聚焦自己要解决的问题， @rogerogers 提交了个 PR 统一优化了格式 #1069

后面在跳出了一个 PR 把 - 改为 * ，我认为，将 - 修改为 * 是符合预期的、提升文档规范性的行为，不需要刻意避免，而且难以避免，反复收割，不会出现这种情况吧？

@rogerogers
Copy link
Contributor

难解，不过好像更多人用 -

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogerogers rogerogers rogerogers left review comments

@GuangmingLuo GuangmingLuo GuangmingLuo approved these changes

Assignees
No one assigned
Labels
Kitex
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ShawnJeffersonWang @CLAassistant @li-jin-gou @L33Z22L11 @GuangmingLuo @rogerogers