Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Handle uri directly instead of redirecting #1083

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

nanakura
Copy link

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

如果当前路由无法匹配,但存在带(不带)尾部斜杠的handler,则自动启用该handler。

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@nanakura nanakura requested review from a team as code owners March 28, 2024 11:17
@li-jin-gou
Copy link
Member

cc @cloudwego/hertz-maintainers

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 82.61%. Comparing base (b7cbc9d) to head (6325524).

❗ Current head 6325524 differs from pull request most recent head e1231dd. Consider uploading reports for the commit e1231dd to get more accurate results

Files Patch % Lines
pkg/route/engine.go 0.00% 16 Missing and 1 partial ⚠️
pkg/app/server/option.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1083      +/-   ##
===========================================
- Coverage    82.79%   82.61%   -0.19%     
===========================================
  Files           98       98              
  Lines        10032    10054      +22     
===========================================
  Hits          8306     8306              
- Misses        1236     1257      +21     
- Partials       490      491       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Skyenought Skyenought left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nanakura
Copy link
Author

nanakura commented Apr 2, 2024

@li-jin-gou 下一步该做什么

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants