feat: support thrift and pb multi-service #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marina-Sakai
force-pushed
the
feat/thrift_pb_multi_service
branch
2 times, most recently
from
15910ae
to
5a041cf
Compare
Marina-Sakai
force-pushed
the
feat/thrift_pb_multi_service
branch
3 times, most recently
from
a9db309
to
3f8019d
Compare
Marina-Sakai
force-pushed
the
feat/thrift_pb_multi_service
branch
from
51831b7
to
6b3b72d
Compare
Marina-Sakai
commented
Mar 21, 2024
felix021
previously approved these changes
Mar 21, 2024
Marina-Sakai
commented
May 31, 2024
| @@ -104,7 +107,7 @@ protoc --go-grpc_out=grpc_gen/. ./idl/grpc_demo_2.proto | |||
|
|
|||
| # Init dependencies | |||
| go get github.com/apache/thrift@v0.13.0 | |||
| go get github.com/cloudwego/kitex@develop | |||
| GOPROXY=direct go get github.com/cloudwego/kitex@fix/multi_service_with_combine_service | |||
There was a problem hiding this comment.
TODO: revert before merging
Marina-Sakai
force-pushed
the
feat/thrift_pb_multi_service
branch
from
f785dd8
to
010dcfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: