Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]feat: check default value type #56

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP]feat: check default value type #56

wants to merge 1 commit into from

Conversation

jayantxie
Copy link
Member

@jayantxie jayantxie commented Aug 11, 2022 •
edited

Kind

feat

Description

zh:

  1. 修复optional的枚举类型添加默认值时的报错问题
  2. 增加thrift默认值类型校验

en:

  1. Fixed an error when adding default values to optional enumeration types
  2. Add thrift default value type check

@jayantxie jayantxie requested a review from lsjbd August 11, 2022 10:34
@jayantxie jayantxie force-pushed the feat/check_default_value_type branch from 5283ae3 to 3790b20 Compare August 11, 2022 11:02
@CLAassistant
Copy link

CLAassistant commented Nov 22, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@jayantxie jayantxie changed the title feat: check default value type [WIP]feat: check default value type Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsjbd lsjbd Awaiting requested review from lsjbd

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jayantxie @CLAassistant