Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[multiplex] merge flush and use sharded hashmap #321 #322

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[multiplex] merge flush and use sharded hashmap #321 #322

wants to merge 1 commit into from
+337 −104

Conversation

miamia0
Copy link

@miamia0 miamia0 commented Jan 8, 2024 •
edited

Motivation

optimize the multiplex transport

  1. use shared hashmap instead of Mutex to reduce race
  2. merge the flush in the write loop

Solution

@miamia0 miamia0 requested review from a team as code owners January 8, 2024 06:47
@CLAassistant
Copy link

CLAassistant commented Jan 8, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@miamia0 miamia0 changed the title [multiplex] merge flush and use shared hashmap #321 [WIP][multiplex] merge flush and use shared hashmap #321 Jan 8, 2024
@choleraehyq
Copy link

shared -> sharded?

@miamia0 miamia0 mentioned this pull request Jan 8, 2024
Open
@miamia0 miamia0 force-pushed the merge_flush branch 3 times, most recently from 8819746 to 98b1479 Compare January 9, 2024 15:34
@miamia0 miamia0 changed the title [WIP][multiplex] merge flush and use shared hashmap #321 [multiplex] merge flush and use shared hashmap #321 Jan 9, 2024
@miamia0 miamia0 changed the title [multiplex] merge flush and use shared hashmap #321 [multiplex] merge flush and use sharded hashmap #321 Jan 10, 2024
@miamia0
Copy link
Author

miamia0 commented Jan 10, 2024

@PureWhiteWu PTAL

choleraehyq
choleraehyq reviewed Jan 11, 2024
View reviewed changes
volo-thrift/src/transport/mod.rs
@@ -1,5 +1,4 @@
pub(crate) mod incoming;
#[cfg(feature = "multiplex")]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里为什么删了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choleraehyq choleraehyq choleraehyq left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miamia0 @CLAassistant @choleraehyq