ETL hits accumulation on a pixel-basis in MTD Validation

[rdelliga]

PR description:
The accumulation process in MTD validation, based on modules (DetId), is updated to be pixel-level during SimHits processing, aligning it with the digitization of ETL[1]; in particular, this may impact processes under high pile-up conditions.
To be consistent with PR #43762, which changes the ETL digitization, it is important to rectify this discrepancy.
A correction attempt has already been made with the failed pull request #43928.
The Digi structure (ETLSample) has been also updated to accomodate for one additional parameter, the time over threshold, therefore some plots to monitor Tot are added in EtlDigiHitsValidation.
Moreover, debugging verbosity in ETL digitization and adcSaturation_MIP in mtdDigitizer_cfg.py are updated.
In ETLUnalibratedRecHitAlgo, amplitude for ETL is set to be the time_over_threshold, because reco energy will not be reconstructed; for the same reason, in EtlLocalecoValidation, some plots about reco energy are removed.
Finally, the use of MC truth for tracks and Primary Vertices is updated, to be consistent with PR #43913.

PR validation:
The code was tested on the workflow
24834.0_TTbar_14TeV+2026D98

[1] https://github.com/cms-sw/cmssw/blob/master/SimFastTiming/FastTimingCommon/src/ETLDeviceSim.cc

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44859/40113

• This PR adds an extra 76KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Validation/MtdValidation/plugins/EtlDigiHitsValidation.cc modified in PR(s): Correction of MTD ETL Validation: hits accumulation on a pixel-basis #43928
  • File Validation/MtdValidation/plugins/EtlLocalRecoValidation.cc modified in PR(s): Correction of MTD ETL Validation: hits accumulation on a pixel-basis #43928
  • File Validation/MtdValidation/plugins/EtlSimHitsValidation.cc modified in PR(s): Correction of MTD ETL Validation: hits accumulation on a pixel-basis #43928
  • File Validation/MtdValidation/plugins/MtdTracksValidation.cc modified in PR(s): Correction of MTD ETL Validation: hits accumulation on a pixel-basis #43928

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44859/40113/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44859/40113/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44859/40115

• This PR adds an extra 76KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Validation/MtdValidation/plugins/EtlDigiHitsValidation.cc modified in PR(s): Correction of MTD ETL Validation: hits accumulation on a pixel-basis #43928
  • File Validation/MtdValidation/plugins/EtlLocalRecoValidation.cc modified in PR(s): Correction of MTD ETL Validation: hits accumulation on a pixel-basis #43928
  • File Validation/MtdValidation/plugins/EtlSimHitsValidation.cc modified in PR(s): Correction of MTD ETL Validation: hits accumulation on a pixel-basis #43928
  • File Validation/MtdValidation/plugins/MtdTracksValidation.cc modified in PR(s): Correction of MTD ETL Validation: hits accumulation on a pixel-basis #43928

[cmsbuild]

A new Pull Request was created by @rdelliga for master.

It involves the following packages:

• RecoLocalFastTime/FTLCommonAlgos (reconstruction, upgrade)
• SimFastTiming/FastTimingCommon (upgrade, simulation)
• Validation/MtdValidation (dqm)

@jfernan2, @syuvivida, @tjavaid, @antoniovagnerini, @srimanob, @mandrenguyen, @civanch, @cmsbuild, @rvenditti, @subirsarkar, @nothingface0, @mdhildreth can you please review it and eventually sign? Thanks.
@fabiocos, @missirol this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test with workflow 27634.0

[fabiocos]

type mtd

[fabiocos]

please test with workflow 27634.0

[fabiocos]

@smuzaffar is there an issue with the test? code-checks look to have passed correctly...

[smuzaffar]

please test workflow 27634.0

@fabiocos , this is the right comment to run extra workflow :-) with is used for extra PRs to be included

[fabiocos]

@smuzaffar oops sorry, my bad!

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3bdfb/39250/summary.html
COMMIT: f60ce34
CMSSW: CMSSW_14_1_X_2024-05-05-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44859/39250/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 258 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3429896
• DQMHistoTests: Total failures: 3813
• DQMHistoTests: Total nulls: 21
• DQMHistoTests: Total successes: 3426042
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -40.019 KiB( 48 files compared)
• DQMHistoSizes: changed ( 23234.0,... ): -5.717 KiB MTD/ETL
• Checked 207 log files, 169 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[jfernan2]

+1

[fabiocos]

@cms-sw/dqm-l2 any comment?

[tjavaid]

+1

[fabiocos]

@cms-sw/upgrade-l2 any doubt/comment about this PR?

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1