Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Introduce OnlinePopCon mechanism #44927

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

francescobrivio
Copy link
Contributor

@francescobrivio francescobrivio commented May 8, 2024

PR description:

This PR introduces a new OnlinePopCon mechanism that will serve the O2Os aiming at writing lumi-based IOVs for HLT.
The implementation is following the same structure of the already existing PopCon mechanism:

and it is largely borrowed from the PopCon code itself, with the appropriate/minimal changes required for running the OnlineDBOutputService.

The first and only (for now) customer of this mechanism are the LHCInfoPerLS and LHCInfoPerFill O2O, when run in "duringFill mode".

Opening as draft since there are still a few open points to address:

  • Understand if m_dbService->forceInit(); (copied from PopCon) is needed also in OnlinePopCon
  • Add a unit-test
  • Confirm all the needed methods are present

PR Validation

Code compiles, but no other specific validation is done for now.

Backport:

Not a backport.
A backport for the 2024 data-taking release will be opened once we converge on this PR.


FYI @JanChyczynski

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44927/40203

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2024

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • CondCore/PopCon (alca, db)

@consuegs, @perrotta, @saumyaphor4252, @francescobrivio, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich, @yuanchao, @tocheng, @PonIlya, @rsreds, @JanChyczynski this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

Copy link
Contributor

@JanChyczynski JanChyczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minors

CondCore/PopCon/interface/OnlinePopCon.h Outdated Show resolved Hide resolved
CondCore/PopCon/src/OnlinePopCon.cc Outdated Show resolved Hide resolved
CondCore/PopCon/src/OnlinePopCon.cc Show resolved Hide resolved
CondCore/PopCon/src/OnlinePopCon.cc Outdated Show resolved Hide resolved
@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44927/40206

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2024

Pull request #44927 was updated. @saumyaphor4252, @perrotta, @francescobrivio, @cmsbuild, @consuegs can you please check and sign again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants