MTD simulation: add support for pre-mixing in pileup management of MtdSimLayerCluster

[fabiocos]

PR description:

The MtdSimLayerCluster collection, used to encode MTD PSimHit clusters and associate them to both TrackingParticle collection and MTD reconstructed hits, was tested to properly handle pile-up in the classic MixingModule case, but was not adapted for pre-mixing.

This PR adds support for the pre-mixing case, and adds a simple analyzer to directly inspect the content of the MtdSimLayerCluster collection.

This addition can possibly serve as a basis for further extension to other MTD-truth collections.

PR validation:

Code compiles, run, and has been tested with the dumper code to combine signal and pile-up in test wf 25034.999.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44941/40213

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @fabiocos for master.

It involves the following packages:

• SimCalorimetry/Configuration (simulation)
• SimDataFormats/CaloAnalysis (simulation)
• SimFastTiming/Configuration (upgrade, simulation)
• SimFastTiming/MtdAssociatorProducers (upgrade, simulation)
• SimGeneral/CaloAnalysis (simulation)
• SimGeneral/PreMixingModule (simulation)

@mdhildreth, @cmsbuild, @srimanob, @civanch, @subirsarkar can you please review it and eventually sign? Thanks.
@slomeo, @sameasy, @rovere, @makortel, @bsunanda, @felicepantaleo, @apsallid, @thomreis, @youyingli, @missirol, @ReyerBand, @wang0jin this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26688b/39322/summary.html
COMMIT: b9f758c
CMSSW: CMSSW_14_1_X_2024-05-08-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44941/39322/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 135.4135.4_ZEEFS_13/step1_ZEEFS_13.log
• 5.15.1_TTbarFS/step1_TTbarFS.log
• 9.09.0_Higgs200ChargedTaus/step3_Higgs200ChargedTaus.log

Expand to see more relval errors ...

• 158.01
• 25.0
• 1306.0
• 1330.0
• 312.0
• 25202.0
• 11634.0
• 13234.0
• 10224.0
• 14034.0
• 14234.0
• 12434.0
• 12846.0
• 12834.0
• 12834.7
• 24896.0
• 24900.0
• 24834.0
• 13034.0
• 23234.0
• 250202.181
• 25034.999
• 24834.911

RelVals-INPUT

• 158.01158.01_HydjetQB12ppRECOin2018reMINIAOD/step2_HydjetQB12ppRECOin2018reMINIAOD.log
• 159.01159.01_HydjetQ_reminiaodPbPb2022_INPUT/step2_HydjetQ_reminiaodPbPb2022_INPUT.log
• 1325.51325.5_ZEE13reMINIAOD/step2_ZEE13reMINIAOD.log

Expand to see more relval errors ...

• 1325.51
• 1325.516
• 1325.5161
• 1325.517
• 1325.518

AddOn Tests

• fastsim

[fastsim:1] cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi  --conditions auto:run1_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - elapsed time: 17 sec (ended on Thu May  9 13:30:25 2024) - exit: 256

• fastsim1

[fastsim1:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - elapsed time: 12 sec (ended on Thu May  9 13:30:25 2024) - exit: 256

• fastsim2

[fastsim2:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - elapsed time: 9 sec (ended on Thu May  9 13:30:25 2024) - exit: 256

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44941/40214

• This PR adds an extra 28KB to repository

[cmsbuild]

Pull request #44941 was updated. @cmsbuild, @subirsarkar, @mdhildreth, @civanch, @srimanob can you please check and sign again.

[fabiocos]

please test

the last fix used in tests was not properly committed

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26688b/39326/summary.html
COMMIT: e7f49d4
CMSSW: CMSSW_14_1_X_2024-05-08-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44941/39326/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 11 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3332476
• DQMHistoTests: Total failures: 55
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3332401
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[srimanob]

Hi @fabiocos

Thanks for this. Should this PR be tested with Phase-2 premixing workflow?

[fabiocos]

@srimanob we have 25034.999 , that shows the bulk of differences, right?

[civanch]

+1

[srimanob]

@srimanob we have 25034.999 , that shows the bulk of differences, right?

Right, thanks.

[srimanob]

+Upgrade

Difference shows up only in Phase-2 premix workflow, 25034.999, as expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1