Simulation: update the test for the definition of back-scattering from CALO

[fabiocos]

PR description:

The transition from CALO to Tracker is monitored in the Phase2SteppingAction of SimG4Core/Application to define the back-scattering condition of a particle, used to define the corresponding category for BTL PSimHit. This condition was updated in #43142 to cope with the fact that the the transition changed in Phase2 geometries, removing at some point (Tracker version T34) the intermediate step into CSME volume. At that time a check on the distance from the origin was introduced, requiring that the post-step has a smaller distance from the origin than the pre-step. This condition is anyway not always fulfilled, driving to an incorrect classification of hits from back-scattering as secondary.

This PR updates the test so as to fix this issue. Either a direct CALO -> Tracker transition is found, or a CSME -> Tracker transition is tested, with the understanding based on navigation checks that it is possible for particles coming from CALO only. As soon as older geometries will be abandoned, this test will not be any more necessary.

PR validation:

Tested with the debugging verbosity of Phase2SteppingAction and of the CMSSteppingVerbose

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44945/40216

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @fabiocos for master.

It involves the following packages:

• SimG4Core/Application (simulation)

@cmsbuild, @mdhildreth, @civanch can you please review it and eventually sign? Thanks.
@slomeo, @rovere, @bsunanda, @makortel this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a901f/39328/summary.html
COMMIT: 6803e7b
CMSSW: CMSSW_14_1_X_2024-05-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44945/39328/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 15 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3332476
• DQMHistoTests: Total failures: 929
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3331527
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[fabiocos]

@cms-sw/simulation-l2 comments?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44945/40253

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #44945 was updated. @mdhildreth, @civanch, @cmsbuild can you please check and sign again.

[fabiocos]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a901f/39378/summary.html
COMMIT: cfae1d0
CMSSW: CMSSW_14_1_X_2024-05-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44945/39378/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 4.764.76_ZMuSkim2012D/step2_ZMuSkim2012D.log

Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338976
• DQMHistoTests: Total failures: 87
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338869
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[fabiocos]

please test

[cmsbuild]

-1

Failed Tests: UnitTests RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a901f/39380/summary.html
COMMIT: cfae1d0
CMSSW: CMSSW_14_1_X_2024-05-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44945/39380/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

RelVals-INPUT

• 4.764.76_ZMuSkim2012D/step2_ZMuSkim2012D.log

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338976
• DQMHistoTests: Total failures: 78
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338878
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[civanch]

Seems to be a DAS problem. Should we ignore this or restart tests?

[fabiocos]

please test

let's try again...

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a901f/39398/summary.html
COMMIT: cfae1d0
CMSSW: CMSSW_14_1_X_2024-05-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44945/39398/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 16 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338976
• DQMHistoTests: Total failures: 84
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338872
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1