-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-hgc355A Complete the PR #44907 by adding the dd4hep of the algorithm DDHGCalPassive to be used for the V19 Geometry of HGCal #44966
Conversation
…HGCalPassive to be used for the V19 Geometry of HGCal
cms-bot internal usage |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44966/40243
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44966/40245
|
A new Pull Request was created by @bsunanda for master. It involves the following packages:
@bsunanda, @Dr15Jones, @makortel, @mdhildreth, @srimanob, @cmsbuild, @civanch, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d5f2c/39367/summary.html Comparison SummarySummary:
|
+1 |
Hi @bsunanda |
@srimanob This will be used in a future code for silicon modules of HGCal. The code is under testing |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Complete PR #44907 by adding the dd4hep of the algorithm DDHGCalPassive to be used for the V19 Geometry of HGCal
PR validation:
Use the test in #44907
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Nothing special