-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ScoutingMuonNoVtx and ScoutingMuonVtx in Run3Scouting Nano starting from 2024 data taking #44970
base: master
Are you sure you want to change the base?
Add ScoutingMuonNoVtx and ScoutingMuonVtx in Run3Scouting Nano starting from 2024 data taking #44970
Conversation
…oducing Run3_post2023 era modifier and add it to Eras for cmsDriver accordingly
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44970/40251
|
A new Pull Request was created by @patinkaew for master. It involves the following packages:
@rappoccio, @hqucms, @fabiocos, @vlimant, @antoniovilela, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@@ -0,0 +1,3 @@ | |||
import FWCore.ParameterSet.Config as cms | |||
|
|||
run3_scouting_nanoAOD_post2023 = cms.Modifier() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove the intermediate run3_scouting_nanoAOD_post2023
modifier, unless there's a citable policy to do so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I might be completely wrong here. From here, I understand that top level like Run3
as ModifierChain
has no method like toModify
or toReplaceWith
. Therefore, I create run3_scouting_nanoAOD_post2023
as Modifier
and call toReplaceWith
to replace the tables.
please include a test workflow in the nano matrix |
enable nano |
our initial comment in #44817 about having |
@patinkaew : please go ahead and modify back to |
This is what was already done in #43761 (now amended to comply with PPD prescription). This PR could simply piggy-back on that one (once merged). |
Thanks. I'm waiting for #43761 to get merged and then I will make changes accordingly. |
PR description:
This PR adds two versions of scouting muon collections, ScoutingMuonNoVtx and ScoutingMuonVtx, following this change CMSHLT-3089:Add hltScoutingMuonPackerVtx to Scouting EventContent.
This fixes issue Missing "hltScoutingMuonPacker" in ScoutingNANO using recent Run-3 data#44817.
This PR also introduces
run3_scouting_nanoAOD_post2023
Modifier used to modify configuration and top levelRun3_post2023
ModifierChain based onRun3
withrun3_scouting_nanoAOD_post2023
Modifier.PR validation:
Tested by producing scouting NanoAOD from a 2024 scouting HLTSCOUT datatier file using the following
cmsDriver.py
command:If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR is not a backport, but backport to 140X will follow.
cc: @elfontan @karim @silviodonato @vlimant