Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ScoutingMuonNoVtx and ScoutingMuonVtx in Run3Scouting Nano starting from 2024 data taking #44970

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

patinkaew
Copy link

PR description:

This PR adds two versions of scouting muon collections, ScoutingMuonNoVtx and ScoutingMuonVtx, following this change CMSHLT-3089:Add hltScoutingMuonPackerVtx to Scouting EventContent.

This fixes issue Missing "hltScoutingMuonPacker" in ScoutingNANO using recent Run-3 data#44817.

This PR also introduces run3_scouting_nanoAOD_post2023 Modifier used to modify configuration and top level Run3_post2023 ModifierChain based on Run3 with run3_scouting_nanoAOD_post2023 Modifier.

PR validation:

Tested by producing scouting NanoAOD from a 2024 scouting HLTSCOUT datatier file using the following cmsDriver.py command:

cmsDriver.py step2 -s NANO:@Scout --process NANO \
--data --eventcontent NANOAOD --datatier NANOAOD -n 10000 \
--era Run3_post2023 --conditions auto:run3_data --filein fileIN.root

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not a backport, but backport to 140X will follow.

cc: @elfontan @karim @silviodonato @vlimant

…oducing Run3_post2023 era modifier and add it to Eras for cmsDriver accordingly
@cmsbuild
Copy link
Contributor

cmsbuild commented May 14, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44970/40251

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @patinkaew for master.

It involves the following packages:

  • Configuration/Eras (operations)
  • Configuration/StandardSequences (operations)
  • PhysicsTools/NanoAOD (xpog)

@rappoccio, @hqucms, @fabiocos, @vlimant, @antoniovilela, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @slomeo, @fabiocos, @felicepantaleo, @VourMa, @VinInn, @sameasy, @missirol, @makortel, @mtosi, @mmusich, @gpetruc, @Martin-Grunewald, @JanFSchulte, @AnnikaStein, @dgulhan this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@@ -0,0 +1,3 @@
import FWCore.ParameterSet.Config as cms

run3_scouting_nanoAOD_post2023 = cms.Modifier()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the intermediate run3_scouting_nanoAOD_post2023 modifier, unless there's a citable policy to do so

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I might be completely wrong here. From here, I understand that top level like Run3 as ModifierChain has no method like toModify or toReplaceWith. Therefore, I create run3_scouting_nanoAOD_post2023 as Modifier and call toReplaceWith to replace the tables.

@vlimant
Copy link
Contributor

vlimant commented May 14, 2024

please include a test workflow in the nano matrix

@vlimant
Copy link
Contributor

vlimant commented May 14, 2024

enable nano

@vlimant
Copy link
Contributor

vlimant commented May 14, 2024

our initial comment in #44817 about having Run3_post2023 instead of Run3_2024 and Run3_2025 was to simplify things and limit the number of modifiers. if @cms-sw/orp-l2 and others feel otherwise, we might roll back to Run3_2024 and Run3_2025

@vlimant
Copy link
Contributor

vlimant commented May 21, 2024

@patinkaew : please go ahead and modify back to Run3_2024 and we will also need a dedicated "scenario" (similar to https://github.com/cms-sw/cmssw/blob/master/Configuration/DataProcessing/python/Impl/ppEra_Run3_2023.py) to be able to run this at Tier0 ; I'm rusty with how to implement this exactly ...

@mmusich
Copy link
Contributor

mmusich commented May 22, 2024

lease go ahead and modify back to Run3_2024 and we will also need a dedicated "scenario"

This is what was already done in #43761 (now amended to comply with PPD prescription). This PR could simply piggy-back on that one (once merged).

@patinkaew
Copy link
Author

Thanks. I'm waiting for #43761 to get merged and then I will make changes accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants