Refactor Makefile and Dockerfile #47
Draft
+234
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcsirot
force-pushed
the
add-jenkinsfile
branch
2 times, most recently
from
e3808b6
to
6bfd7c9
Compare
chris-crone
reviewed
Jun 12, 2019
|
|
||
| # Fetch docker cli to run a registry container for e2e tests | ||
| RUN curl -Ls https://download.docker.com/linux/static/$DOCKERCLI_CHANNEL/x86_64/docker-$DOCKERCLI_VERSION.tgz | tar -xz | ||
|
|
||
| # Fetch docker-app to build a CNAB from an application template | ||
| RUN curl -Ls https://github.com/docker/app/releases/download/$DOCKER_APP_VERSION/docker-app-linux.tar.gz | tar -xz | ||
| RUN git clone https://github.com/docker/app | ||
| RUN curl -Ls https://github.com/docker/app/releases/download/$DOCKER_APP_VERSION/docker-app-linux.tar.gz | tar -xz && cp /go/docker-app-linux /usr/bin/docker-app |
There was a problem hiding this comment.
We should bump the version we use to the lastest release of Docker App. I see above that it's the cnab-preview one
| @@ -0,0 +1,17 @@ | |||
| ARG ALPINE_VERSION=3.8 | |||
| ARG GO_VERSION=1.11.4 | |||
There was a problem hiding this comment.
These versions are quite old, would be good to bump them
Signed-off-by: Jean-Christophe Sirot <jean-christophe.sirot@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Jenkinsfile