Make edit links multilingual-aware #639
Conversation
Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
cjyabraham
requested review from
thschue,
joshgav,
lianmakesthings,
kgamanji and
angellk
as code owners
✅ Deploy Preview for tag-app-delivery ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Thanks @cjyabraham for the super quick fix! I think this works if the page exists. Unfortunately that is not always the case 😢
The newest solution for keeping overhead on language support low has been to auto copy english to the language directories only on deploy (#611). That means that the page may appear to exist in the browser, but not exist in GH.
Example would be that editing this page gets a 404 in GH whereas editing this page works great now!
Would there be a way to indicate that being the case with a marker of some sort? Since we are generating, we can add another label or something if that helps?
|
The problem is, the duplicated page itself doesn't know it's duplicated. I didn't want to make it too complex, that's why the duplication happens during build, and not before. But I think this PR will already fix a most of the cases, so I propose to merge this one first and continue this discussion in #637 |
Fixes #637