Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes Image ref in Chinese Platforms Whitepaper #623

Closed
wants to merge 1 commit into from

Conversation

lianmakesthings
Copy link
Collaborator

In the Chinese translation of the platforms whitepaper, a non-existing image platforms-def.drawio.zh.png is referenced.
This PR displays the English version of the image as long as the chinese version does not exist

@node

Signed-off-by: lianmakesthings <hi@lianmakesthings.dev>
Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for tag-app-delivery ready!

Name Link
🔨 Latest commit ca2eb89
🔍 Latest deploy log https://app.netlify.com/sites/tag-app-delivery/deploys/661e5cd29c6c50000836d22e
😎 Deploy Preview https://deploy-preview-623--tag-app-delivery.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@node
Copy link
Contributor

node commented Apr 16, 2024

I will check it later . Thank you.
😄

//UPDATE
I realized that when I submitted the Chinese translation previously, I did omit the image files; we actually translated the images at that time as well.
Now there are 2 alternatives to try:

  1. merge this PR first, and then I submit the image file via another new PR.
  2. I'll submit a new PR directly to make sure it's fixed, and then I can close this PR.

@lianmakesthings
Copy link
Collaborator Author

Let's go with option 1, then there's no pressure on you to submit the translated image :)

Copy link
Collaborator

@abangser abangser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find. Also looking forward to the translated version being stored in source control so that we have more durability with the image.

Thanks!

@node
Copy link
Contributor

node commented May 10, 2024

Created new PR #648 for adding the missing picture.

@lianmakesthings
Copy link
Collaborator Author

Closed in favour of #648

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants