Suggested rewording and new questions #640
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bryan Ross <bryan@liquidstate.net>
bryanrossUK
requested review from
thschue,
joshgav,
lianmakesthings,
kgamanji and
angellk
as code owners
✅ Deploy Preview for tag-app-delivery ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Given this is a narrow scoped change, I will suggest that once there is consensus within the platform as a product project group (at least 2 or 3 👍 ) we can ping one of the TAG leads directly for approval to merge. For future context to the tag leads, this is a WIP piece of work that we wanted version controlled, but it is not an officially "published" piece so does not need formal review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mluskind - here's some suggested changes after our chat last week. I'm not wed to any, so please feel free to use or ignore as you see fit.