resolve rules_go conflict #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kuat Yessenov <kuat@google.com>
|
/assign @htuch |
|
I think this will unblock us bumping the |
|
@moderation There are other dependencies with conflicts, but this one is a real blocker. The others can be done in follow ups. |
htuch
approved these changes
Dec 11, 2020
|
@kyessenov I can confirm there are still conflicts after using this commit. Unable to use Go |
|
It's a painful process of changing every protobuf/ptypes dependency to rules_go. This works for core envoy types and PGV, but needs follow up for opencensus, etc. This is the right thing to do anyways, we've just been procrastinating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed by envoyproxy/envoy#14253
Signed-off-by: Kuat Yessenov kuat@google.com