Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: lock babel-traverse 7.17.10 to 7.17.9" #193

Conversation

liuxingbaoyu
Copy link
Contributor

Reverts #192

babel/minify#1028 (comment)

这个是babel-minify依赖了有bug的行为,babel-traverse本身没问题

@fengmk2
Copy link
Member

fengmk2 commented May 10, 2022

@atian25 看看是否需要回滚

@atian25
Copy link
Contributor

atian25 commented May 11, 2022

@liuxingbaoyu 我看 babel-minify 那个好像还是 open 的,那是需要 bug-version 它然后回滚这个还是?

@typistZxd
Copy link

typistZxd commented May 11, 2022

降版本导致现在很多项目有间接依赖到 @babel/traverse 都出现安装时候hash对不上(比如@babel/core),影响比较大,建议尽快排查恢复...

@liuxingbaoyu
Copy link
Contributor Author

liuxingbaoyu commented May 11, 2022

我不太清楚 cnpm 以前是怎么处理这种情况的
个人认为可以不管这个问题或者把 babel-minify 重定向到新版

毕竟 @babel/traverse 那边团队只是当做bug修复,以后再有新版还会保持一样的行为
另外 babel-minify 之前已经3年没更新了,@babel/traverse 用户也多得多

周下载:
babel-minify:13,609
@babel/traverse:29,211,489

@fz6m
Copy link

fz6m commented May 11, 2022

+1 ,@babel/traverse 被太多 babel 依赖所使用,有 babel 最新依赖的项目都报错构建失败了。

@fengmk2 fengmk2 merged commit 1e9a09f into cnpm:master May 12, 2022
@fengmk2
Copy link
Member

fengmk2 commented May 12, 2022

  • bug-versions@1.75.0

@cnpm cnpm deleted a comment from github-actions bot May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants