Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont add quotes on node global bin path on Windows #317

Merged
merged 1 commit into from
Dec 7, 2019

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Dec 7, 2019

need to wait for npm/cmd-shim#42
to be merged and publish a new version.

closes #316

need to wait for npm/cmd-shim#42
to be merged and publish a new version.

closes #316
@fengmk2
Copy link
Member Author

fengmk2 commented Dec 7, 2019

一个双引号引发的 windows cmd 写错的血案。

@fengmk2
Copy link
Member Author

fengmk2 commented Dec 7, 2019

@atian25 多年的 windows 难题解决了。

@fengmk2 fengmk2 added the bug label Dec 7, 2019
@fengmk2 fengmk2 merged commit e0be08b into master Dec 7, 2019
@fengmk2 fengmk2 deleted the use-cmd-shim-hotfix branch December 7, 2019 14:40
fengmk2 added a commit that referenced this pull request Dec 7, 2019
fengmk2 added a commit that referenced this pull request Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@ not work on windows bin path
1 participant