Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setting charset #3862

Open
jayvdb opened this issue Mar 7, 2017 · 10 comments · May be fixed by #6064
Open

Add setting charset #3862

jayvdb opened this issue Mar 7, 2017 · 10 comments · May be fixed by #6064
Assignees
@jackthepirate6
Labels
difficulty/low importance/medium

Comments

@jayvdb
Copy link
Member

jayvdb commented Mar 7, 2017

#3529 show the problem with non -utf8 content.

We need a setting so users can control the charset used, which will reduce the severity of above bug.
@jack17529
Copy link
Contributor

@jayvdb please assign me this.

@Makman2
Copy link
Member

Makman2 commented Mar 9, 2017

@jack17529 please read our newcomer guide

@jack17529
Copy link
Contributor

@Makman2 already did it sir , no newcomer issues are present

@jayvdb
Copy link
Member Author

jayvdb commented Mar 10, 2017

There are 7. They are not in this repo. The newcomer guide explains how to find them.

@yogupta
Copy link
Contributor

yogupta commented Mar 10, 2017

Setting for which Bear?

@jayvdb
Copy link
Member Author

jayvdb commented Mar 10, 2017

This problem is not about a specific bear; the file open code is in coala. This is a fix for problems like #488

@yogupta
Copy link
Contributor

yogupta commented Mar 11, 2017

when i run coala -f *.jpg . i get warning as �[33m[WARNING]�[0m[17:17:07] coala will not run any analysis. Did you forget to give the --bears argument?�[0m . (only one line warning).

we just need to add options like coala -f xyz.png --encoding *typehere* ?

i'm not getting , can you please explain more 😅

@jayvdb
Copy link
Member Author

jayvdb commented Mar 11, 2017

Ya, those are binary files. Binary files do not have a charset. Test on a text file which uses a different character encoding, i.e. not utf8.

@yogupta yogupta mentioned this issue Mar 16, 2017
Closed
2 tasks
@jackthepirate6
Copy link
Member

I will work on this issue

@Makman2
Copy link
Member

Makman2 commented Feb 12, 2018

Reassigning due to inactivity.

@Makman2 Makman2 assigned jackthepirate6 and unassigned yogupta Feb 12, 2018
Utkarsh1308 added a commit to Utkarsh1308/coala that referenced this issue Aug 21, 2019
@Utkarsh1308
Provide support for non utf-8 encodings
54ba270 
coala currently only supports utf-8 encodings. Before merging this
we need to add support for non utf-8 encodings to coala-utils.

Some bears like SpellCheckBear have external linters which only
support utf-8 encodings. To solve this the bears should describe
the encoding it can handle followed by coala creating a temporary
file in the linter's accepted encoding (Converting utf-16 to utf-8)

Some encodings have glyphs which are not in unicode and can't be
transcoded to utf16/32. We should write test to catch such
exceptions.

Closes coala#3862
Utkarsh1308 added a commit to Utkarsh1308/coala that referenced this issue Aug 21, 2019
@Utkarsh1308
Provide support for non utf-8 encodings
72098fe 
coala currently only supports utf-8 encodings. Before merging this
we need to add support for non utf-8 encodings to coala-utils.

Some bears like SpellCheckBear have external linters which only
support utf-8 encodings. To solve this the bears should describe
the encoding it can handle followed by coala creating a temporary
file in the linter's accepted encoding (Converting utf-16 to utf-8)

Some encodings have glyphs which are not in unicode and can't be
transcoded to utf16/32. We should write test to catch such
exceptions.

Closes coala#3862
Utkarsh1308 added a commit to Utkarsh1308/coala that referenced this issue Aug 21, 2019
@Utkarsh1308
Provide support for non utf-8 encodings
f0de42d 
coala currently only supports utf-8 encodings. Before merging this
we need to add support for non utf-8 encodings to coala-utils.

Some bears like SpellCheckBear have external linters which only
support utf-8 encodings. To solve this the bears should describe
the encoding it can handle followed by coala creating a temporary
file in the linter's accepted encoding (Converting utf-16 to utf-8)

Some encodings have glyphs which are not in unicode and can't be
transcoded to utf16/32. We should write test to catch such
exceptions.

Closes coala#3862
Utkarsh1308 added a commit to Utkarsh1308/coala that referenced this issue Aug 21, 2019
@Utkarsh1308
Provide support for non utf-8 encodings
5c6d779 
coala currently only supports utf-8 encodings. Before merging this
we need to add support for non utf-8 encodings to coala-utils.

Some bears like SpellCheckBear have external linters which only
support utf-8 encodings. To solve this the bears should describe
the encoding it can handle followed by coala creating a temporary
file in the linter's accepted encoding (Converting utf-16 to utf-8)

Some encodings have glyphs which are not in unicode and can't be
transcoded to utf16/32. We should write test to catch such
exceptions.

Closes coala#3862
Utkarsh1308 added a commit to Utkarsh1308/coala that referenced this issue Aug 21, 2019
@Utkarsh1308
Provide support for non utf-8 encodings
b415eea 
coala currently only supports utf-8 encodings. Before merging this
we need to add support for non utf-8 encodings to coala-utils.

Some bears like SpellCheckBear have external linters which only
support utf-8 encodings. To solve this the bears should describe
the encoding it can handle followed by coala creating a temporary
file in the linter's accepted encoding (Converting utf-16 to utf-8)

Some encodings have glyphs which are not in unicode and can't be
transcoded to utf16/32. We should write test to catch such
exceptions.

Closes coala#3862
@Utkarsh1308 Utkarsh1308 linked a pull request Aug 21, 2019 that will close this issue
Open
2 tasks
Utkarsh1308 added a commit to Utkarsh1308/coala that referenced this issue Aug 26, 2019
@Utkarsh1308
Provide support for non utf-8 encodings
bbea741 
coala currently only supports utf-8 encodings. Before merging this
we need to add support for non utf-8 encodings to coala-utils.

Some bears like SpellCheckBear have external linters which only
support utf-8 encodings. To solve this the bears should describe
the encoding it can handle followed by coala creating a temporary
file in the linter's accepted encoding (Converting utf-16 to utf-8)

Some encodings have glyphs which are not in unicode and can't be
transcoded to utf16/32. We should write test to catch such
exceptions.

Closes coala#3862
Utkarsh1308 added a commit to Utkarsh1308/coala that referenced this issue Aug 26, 2019
@Utkarsh1308
Provide support for non utf-8 encodings
72408b0 
coala currently only supports utf-8 encodings. Before merging this
we need to add support for non utf-8 encodings to coala-utils.

Some bears like SpellCheckBear have external linters which only
support utf-8 encodings. To solve this the bears should describe
the encoding it can handle followed by coala creating a temporary
file in the linter's accepted encoding (Converting utf-16 to utf-8)

Some encodings have glyphs which are not in unicode and can't be
transcoded to utf16/32. We should write test to catch such
exceptions.

Closes coala#3862
Utkarsh1308 added a commit to Utkarsh1308/coala that referenced this issue Aug 26, 2019
@Utkarsh1308
Provide support for non utf-8 encodings
dc0b01c 
coala currently only supports utf-8 encodings. Before merging this
we need to add support for non utf-8 encodings to coala-utils.

Some bears like SpellCheckBear have external linters which only
support utf-8 encodings. To solve this the bears should describe
the encoding it can handle followed by coala creating a temporary
file in the linter's accepted encoding (Converting utf-16 to utf-8)

Some encodings have glyphs which are not in unicode and can't be
transcoded to utf16/32. We should write test to catch such
exceptions.

Closes coala#3862
Utkarsh1308 added a commit to Utkarsh1308/coala that referenced this issue Aug 26, 2019
@Utkarsh1308
Provide support for non utf-8 encodings
f4cc723 
coala currently only supports utf-8 encodings. Before merging this
we need to add support for non utf-8 encodings to coala-utils.

Some bears like SpellCheckBear have external linters which only
support utf-8 encodings. To solve this the bears should describe
the encoding it can handle followed by coala creating a temporary
file in the linter's accepted encoding (Converting utf-16 to utf-8)

Some encodings have glyphs which are not in unicode and can't be
transcoded to utf16/32. We should write test to catch such
exceptions.

Closes coala#3862
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackthepirate6 jackthepirate6

Labels
difficulty/low importance/medium
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide support for non utf-8 encodings Utkarsh1308/coala
DefaultArgParser.py: Add setting charset
5 participants
@jayvdb @Makman2 @jack17529 @yogupta @jackthepirate6