Provide support for non utf-8 encodings #6064
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a problem with These should get fixed when https://gitlab.com/coala/coala-utils/merge_requests/99 gets merged |
Utkarsh1308
force-pushed
the
charset
branch
9 times, most recently
from
92132d0
to
42becaa
Compare
coala currently only supports utf-8 encodings. Before merging this we need to add support for non utf-8 encodings to coala-utils. Some bears like SpellCheckBear have external linters which only support utf-8 encodings. To solve this the bears should describe the encoding it can handle followed by coala creating a temporary file in the linter's accepted encoding (Converting utf-16 to utf-8) Some encodings have glyphs which are not in unicode and can't be transcoded to utf16/32. We should write test to catch such exceptions.
gr455
approved these changes
Dec 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coala currently only supports utf-8 encodings. Before merging this
we need to add support for non utf-8 encodings to coala-utils.
Some bears like SpellCheckBear have external linters which only
support utf-8 encodings. To solve this the bears should describe
the encoding it can handle followed by coala creating a temporary
file in the linter's accepted encoding (Converting utf-16 to utf-8)
Some encodings have glyphs which are not in unicode and can't be
transcoded to utf16/32. We should write test to catch such
exceptions.
Closes #3862
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
corobo mark wip <URL>to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!