Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting.py: Change property name #5983

Open
akshatkarani opened this issue Feb 10, 2019 · 24 comments · May be fixed by #6071
Open

Setting.py: Change property name #5983

akshatkarani opened this issue Feb 10, 2019 · 24 comments · May be fixed by #6071
Labels
difficulty/newcomer type/bug

Comments

@akshatkarani
Copy link
Member

akshatkarani commented Feb 10, 2019 •
edited

The line_number property for Setting class should be changed to start_line_number as it is the starting line number of a setting.
difficulty/newcomer
@aedorado
Copy link

I guess this can be labelled as difficulty/newcomer @jayvdb .
Doing a casual quick search, I mostly saw the use of this line_number property in ConfParserTest.py file.

@GrayR00t
Copy link

I would like to work on this issue.

@ojasgulati
Copy link

@akshatkarani looks like no one working on this. I would like to work on this as a new comer.

ojasgulati added a commit to ojasgulati/coala that referenced this issue May 21, 2019
@ojasgulati
Settings.py: fixed typo
af8659e 
line_number -> start_line_number

Closes coala#5983
@ojasgulati ojasgulati mentioned this issue May 21, 2019
Closed
2 tasks
ojasgulati added a commit to ojasgulati/coala that referenced this issue May 21, 2019
@ojasgulati
Settings.py: fixed typo
045f86b 
line_number -> start_line_number

Closes coala#5983
@hv7214
Copy link

hv7214 commented Jun 13, 2019

@akshatkarani anyone working on this issue?

@akshatkarani
Copy link
Member Author

akshatkarani commented Jun 13, 2019 •
edited

Ask on our gitter channel to get this issue assigned to yourself.

@anonymone
Copy link
Member

anonymone commented Jul 26, 2019 •
edited

Have anyone worked on this issue? if not, I am so glad to do it.

@imnitishng
Copy link

Seems like the issue is not fixed yet. I would like to work on this, please assign it to me.

@Dilshaad21
Copy link
Contributor

I would like to work on this issue.

@imnitishng imnitishng mentioned this issue Sep 10, 2019
Closed
imnitishng added a commit to imnitishng/coala that referenced this issue Sep 10, 2019
@imnitishng
Setting.py: Change property name
bd00a9d 
Change property name in class `Setting` from `line_number` --> `start_line_number`

Fixes coala#5983
@imnitishng imnitishng linked a pull request Sep 10, 2019 that will close this issue
Open
2 tasks
imnitishng added a commit to imnitishng/coala that referenced this issue Sep 11, 2019
@imnitishng
Setting.py: Change property name
b51046c 
Change property name from line_number-->start_line_number

Fixes coala#5983
imnitishng added a commit to imnitishng/coala that referenced this issue Sep 11, 2019
@imnitishng
Setting.py: Change property name
d7af210 
Change property name from line_number-->start_line_number

Fixes coala#5983
imnitishng added a commit to imnitishng/coala that referenced this issue Sep 12, 2019
@imnitishng
Setting.py: Change property name
8b97b4a 
Change property name from line_number-->start_line_number

Closes coala#5983
imnitishng added a commit to imnitishng/coala that referenced this issue Sep 12, 2019
@imnitishng
Setting.py: Change property name
73377ec 
Change property name from line_number-->start_line_number

Closes coala#5983
This was referenced Sep 17, 2019
Closed
Closed
@nick-martin-24
Copy link

Trying to figure this stuff out. Anyone know why the first two builds failed?

@tylerviducic
Copy link

I would like to work on this.

@tylerviducic tylerviducic mentioned this issue Oct 2, 2019
Closed
@espatatis
Copy link

Can I get this issue assigned ?

@aarsh-sharma
Copy link

I see this issue has not been assigned yet. Can I get this issue assigned.
Thank you.

@him-mah10 him-mah10 mentioned this issue Oct 13, 2019
Closed
@cyb3rpr0
Copy link

Hi, newcomer here. Is there something I can do to help?

@neha629
Copy link

neha629 commented Oct 15, 2019

Can I get this issue assigned ?

@bugsz
Copy link

bugsz commented Nov 12, 2019

Can I get this issue assigned ?

@NamugumyaSandra
Copy link

Hello team, Can I take on this task?

@Blackcipher101
Copy link

@akshatkarani Can I get this issue assigned. Thank you

@gr455
Copy link

gr455 commented Dec 15, 2019

@Blackcipher101 This issue already has 4 PRs on it. Review them instead of sending your own

@Saanidhyavats
Copy link

I am interested to take up this issue

Saanidhyavats added a commit to Saanidhyavats/coala that referenced this issue Dec 27, 2019
@Saanidhyavats
coala#5983 (Replaces line_number with start_line_number)
2605424
@Saanidhyavats Saanidhyavats mentioned this issue Dec 29, 2019
Closed
2 tasks
@faraz16iqbal
Copy link

Is this issue still up for grabs?

@akshatkarani
Copy link
Member Author

@faraz16iqbal No

@joesinghh
Copy link

hey @akshatkarani , can you please assign this issue to me

@tichnas
Copy link

tichnas commented Dec 11, 2020

Hi @akshatkarani, I'm new to coala and would love to work on this issue. Can I please be assigned?
Thanks

@akshatkarani
Copy link
Member Author

@tichnas This issue already has many PRs, find some other issue to work on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/newcomer type/bug
Milestone
No milestone