Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting.py: Change property name #6071

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

imnitishng
Copy link

@imnitishng imnitishng commented Sep 10, 2019

Change property name in class Setting from line_number --> start_line_number

Closes #5983

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@imnitishng
Copy link
Author

imnitishng commented Sep 10, 2019

Okay so this is my second PR now Travis reports ! ! Body of HEAD commit contains too long lines. Commit body lines should not exceed 72 characters. thats fine I understand how to fix it.
The only problem is how do I change the commit message in this PR? Can I do it? Or do I have to create a new branch and then a new PR with the new commit body changes?

@imnitishng imnitishng force-pushed the setting_issue_new branch 2 times, most recently from b51046c to d7af210 Compare September 11, 2019 17:54
@imnitishng
Copy link
Author

Can someone have a look at this PR and merge it? This is my first PR!

Copy link

@frextrite frextrite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @imnitishng. The changes look good, however, change Fixes to Closes in the PR and commit body since this is not a bug.

Change property name from line_number-->start_line_number

Closes coala#5983
@imnitishng
Copy link
Author

Done!

Copy link

@frextrite frextrite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Setting.py: Change property name
4 participants