Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development setup notes: 'installing from git' link can be optimised to not reload the page #5992

Open
harshhx17 opened this issue Feb 14, 2019 · 24 comments · May be fixed by #6077
Open

Development setup notes: 'installing from git' link can be optimised to not reload the page #5992

harshhx17 opened this issue Feb 14, 2019 · 24 comments · May be fixed by #6077
Labels
difficulty/newcomer type/bug

Comments

@harshhx17
Copy link
Contributor

The link reloads the entire page and doesn't even redirect to the required location
Instead it should just be '#installing-from-git'
@abhishalya
Copy link
Member

@harshhx17 It works fine for me. If I'm correct, this link redirects to correct part of the webpage.

@harshhx17
Copy link
Contributor Author

@abhishalya
The link that you have given, works perfectly fine...
Now there are two things that I wanted to say,

  1. If we keep the entire link in href, the page reloads. The point I want to make is that it is inefficient for the entire page to reload, it should just move to the required part if the link is a reference to the same page. This can easily be achieved by replacing the entire link with just #installing-from-git.
  2. Although the link in the master is the one that you say is, the link that is actually present on this page is different.

@VertexC
Copy link

VertexC commented Feb 28, 2019

Hi, is this still a opened bug? @harshhx17 can you assign it to me?

@ashutoshjv661
Copy link

Can you assign me this issue ?
#5992
My first open source contribution

@piyush072
Copy link

Can I be assigned to this bug?

@harshhx17
Copy link
Contributor Author

@jayvdb ^

@abhishalya
Copy link
Member

abhishalya commented Mar 5, 2019 •
edited

@harshhx17 Please update the issue title and description since I think it is not very clear what you were trying to convey. But yeah, for some reason the link on the rendered page is different.

@harshhx17 harshhx17 changed the title Development setup notes: 'installing from git' link not working properly Development setup notes: 'installing from git' link in master is incorrect, and can be optimised to not reload the page Mar 7, 2019
@harshhx17 harshhx17 changed the title Development setup notes: 'installing from git' link in master is incorrect, and can be optimised to not reload the page Development setup notes: 'installing from git' link can be optimised to not reload the page Mar 7, 2019
@vibhor16
Copy link

vibhor16 commented Mar 9, 2019

In which repo can I find the code for the page - https://api.coala.io/en/latest/Developers/Development_Setup.html ?
I can find the link in the Development_Setup.rst file in coala repo, but don't know if this is the link that is used in the url mentioned above.

@vibhor16
Copy link

vibhor16 commented Mar 9, 2019

@PrajwalM2212 Yes I tried looking into the documentation repo, still I couldn't connect if the content in Development_Setup.rst file is used there.

@vibhor16
Copy link

vibhor16 commented Mar 9, 2019

This issue can be seen on the same page in the following location as well :

  • Under Using venv heading: Now you can activate the environment and start the next part.

@vibhor16
Copy link

@harshhx17 Could you please assign me this bug?

@roshnet
Copy link
Member

roshnet commented Mar 22, 2019

This issue still persists. Can I be assigned this one please?

@heshamelsawaf
Copy link

This issue still persists. Can I be assigned this one please?

I have been trying for 6 days now to get someone to assign it to me as my first issue, but sadly no one ever replies :)

@bkhanale
Copy link
Member

@heshamelsawaf @roshnet You need to ping jayvdb or li-boxuan on gitter to assign you the issue.

@heshamelsawaf
Copy link

heshamelsawaf commented Mar 22, 2019 •
edited

@heshamelsawaf @roshnet You need to ping jayvdb or li-boxuan on gitter to assign you the issue.

That is exactly what I did, 2 days ago and yesterday(I pinged li-boxuan in both). And as far as I know, jayvdb is not available nowadays.

@abhishalya
Copy link
Member

@heshamelsawaf You should wait then, almost every maintainer is busy nowadays.

@heshamelsawaf
Copy link

Yeah I guess. I'm just trying to resolve some issues for my GSoC proposal. but anyway I understand they are busy.

Dilshaad21 added a commit to Dilshaad21/coala that referenced this issue Sep 24, 2019
@Dilshaad21
DevelopmentSetup.rst: Change Install from git link
8d10894 
Changed the install from git link from <https://api.coala.io/en/latest/Developers/Development_Setup.html#installing-from-git> -->
<#installing-from-git> to send it to the content in the same page instead of reloading the whole page to the link.
Closes coala#5992
@Dilshaad21 Dilshaad21 linked a pull request Sep 24, 2019 that will close this issue
Open
2 tasks
Dilshaad21 added a commit to Dilshaad21/coala that referenced this issue Sep 25, 2019
@Dilshaad21
DevelopmentSetup.rst:Change install from git link
4f46e92 
Changed the install from git link from <https://api.coala.io/en/
latest/Developers/Development_Setup.html#installing-from-git> -->
<#installing-from-git> to send it to the content in the same page
instead of reloading the whole page to the link.

Closes coala#5992
Dilshaad21 added a commit to Dilshaad21/coala that referenced this issue Sep 25, 2019
@Dilshaad21
DevelopmentSetup.rst:Change install from git link
857624b 
Changed the install from git link from <https://api.coala.io/en/
latest/Developers/Development_Setup.html#installing-from-git> -->
<#installing-from-git> to send it to the content in the same page
instead of reloading the whole page to the link.

Closes coala#5992
Dilshaad21 added a commit to Dilshaad21/coala that referenced this issue Sep 25, 2019
@Dilshaad21
DevelopmentSetup.rst: Change install from git link
a977340 
Changed the install from git link from <https://api.coala.io/en/
latest/Developers/Development_Setup.html#installing-from-git> -->
<#installing-from-git> to send it to the content in the same page
instead of reloading the whole page to the link.

Closes coala#5992
Dilshaad21 added a commit to Dilshaad21/coala that referenced this issue Sep 25, 2019
@Dilshaad21
DevelopmentSetup.rst: Change install from git link
0a96bae 
Change original install from git link --> <#installing-from-git>
to send it to the content in the same page
instead of reloading the whole page to the link.

Closes coala#5992
Dilshaad21 added a commit to Dilshaad21/coala that referenced this issue Sep 25, 2019
@Dilshaad21
Development_Setup.rst: Fix install from git link
725b902 
Change original install from git link --> <#installing-from-git>
to send it to the content in the same page
instead of reloading the whole page to the link.

Closes coala#5992
@KVGarg
Copy link
Contributor

KVGarg commented Sep 28, 2019

The link reloads the entire page and doesn't even redirect to the required location
Instead it should just be '#installing-from-git'

It will not matter even if the link contains the webpage url! The actual issue is that documentation isn't updated! On inspecting the develpement_setup.html in browser the actual link which is present there is https://api.coala.io/en/latest/Developers/Development_Setup.html#id1 instead of https://api.coala.io/en/latest/Developers/Development_Setup.html#installing-from-git.
@abhishalya @harshhx17 Can you guys verify this!
Inspect the last bullet point of venv section

@tyajush
Copy link

tyajush commented Oct 22, 2020

I am a new commer please assing me this issue.
I have understood the issue. I will make it such that, it just move to the required part if the link is a reference to the same page by replacing the entire link with just #installing-from-git.

@tichnas
Copy link

tichnas commented Dec 11, 2020

@harshhx17 @abhishalya Hi, I'm new to coala and would love to work on this issue. Can I please be assigned?
Thanks

@kartikeysaran
Copy link

Hey is issue still open ??

@bkhanale
Copy link
Member

Hey is issue still open ??

Yep, you can work on this if you like :)

@kartikeysaran
Copy link

Yep, you can work on this if you like :)

Okay, i have started working on this

@ghost
Copy link

ghost commented Feb 21, 2023

FYI in the bugs table parent to this thread the assignee for this bug isn't displayed as having been assigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/newcomer type/bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DevelopmentSetup.rst: Change Install from git link Dilshaad21/coala