Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevelopmentSetup.rst: Change Install from git link #6077

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Dilshaad21
Copy link
Contributor

@Dilshaad21 Dilshaad21 commented Sep 24, 2019

Closes #5992

Changed the install from git link from https://api.coala.io/en/latest/Developers/Development_Setup.html#installing-from-git -->
<#installing-from-git> to send it to the content in the same page instead of reloading the whole page to the link.

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

Change original install from git link --> <#installing-from-git>
to send it to the content in the same page
instead of reloading the whole page to the link.

Closes coala#5992
Copy link
Contributor

@KVGarg KVGarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-open the PR! Don't close it un-necessarily, please!

@Dilshaad21 Dilshaad21 reopened this Sep 28, 2019
@Dilshaad21
Copy link
Contributor Author

@KVGarg as there were some failing tests I thought to make a new pr. Anyway I reopened it can you please check where are the checks going wrong. Thanks.

@KVGarg
Copy link
Contributor

KVGarg commented Sep 28, 2019

The build is failing due to JDK as it is not able to to find a suitable version for it. Maybe TravisCI has dropped support for adopt@1.8.212.
Also, I'm still not sure whether the issue which is being solved by this PR is valid or not!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Development setup notes: 'installing from git' link can be optimised to not reload the page
2 participants