Writing_Linter_Bears.rst: Fix broken link #6069
Conversation
|
This solves #5944 |
There was a problem hiding this comment.
Hi @Dilshaad21
Thanks for the PR! The changes look good however please follow the commit guidelines to create commits. The commit should have a short log, a body and reference to the issue that is being fixed.
|
PRs should not be closed. Please modify your existing commit (using |
Dilshaad21
force-pushed
the
link
branch
2 times, most recently
from
5b4d564
to
a431ec8
Compare
Dilshaad21
changed the title
Dilshaad21
force-pushed
the
link
branch
3 times, most recently
from
0c856d8
to
ec627f4
Compare
There was a problem hiding this comment.
@Dilshaad21 the CIs are still failing. Take a look at the error here. The shortlog must be atmost 50 characters, yours is 54 characters long. A possible solution would be to rename the shortlog to something like Writing_Lint_Bears.rst: Fix broken link with the commit body as it is. Thanks.
|
Ok @frextrite .Thanks. |
Dilshaad21
changed the title
|
@frextrite done |
|
@frextrite @jayvdb Please review. |
This solves the broken link issue Change Dive into python <http://www.diveintopython3.net/regular-expressions.html>--> <https://diveintopython3.problemsolving.io/regular-expressions.html> Closes coala#5944
Closes #5944
Changes Dive into python link http://www.diveintopython3.net/regular-expressions.html --> Dive into python http://diveintopython3.problemsolving.io/regular-expressions.html
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
corobo mark wip <URL>to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!