Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused imports #6094

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove unused imports #6094

wants to merge 1 commit into from

Conversation

gr455
Copy link

@gr455 gr455 commented Dec 9, 2019

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

ShowAppliedPatchesActionTest.py , GeneratePatchesActionTest.py : Removes unused imports
Closes #6036

Copy link
Contributor

@KVGarg KVGarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message needs some improvement, do check on how to write a good commit message.

@gr455 gr455 changed the title remove unused imports Remove unused imports Dec 9, 2019
@gr455
Copy link
Author

gr455 commented Jan 9, 2020

@abhishalya Can you please take a look at this

@frextrite
Copy link

@gr455 You just changed the PR title, please fix the commit as well, as suggested by @KVGarg

@gr455
Copy link
Author

gr455 commented Jan 15, 2020

@gr455 You just changed the PR title, please fix the commit as well, as suggested by @KVGarg

Does it look good now?

@frextrite
Copy link

Does it look good now?

@gr455 I don't suppose you changed anything after my latest comment, right? Please amend the commit using git commit --amend and force-push the changes! This will help you!

@gr455
Copy link
Author

gr455 commented Jan 15, 2020

Does it look good now?

@gr455 I don't suppose you changed anything after my latest comment, right? Please amend the commit using git commit --amend and force-push the changes! This will help you!

I changed
'fixes' to closes
and amended the second last line
However I did all this using the 'edit' button here.

Is the PR description here good or are any changes required here as well? I will change the commit and force-push according to the current PR description as of now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Unused and double imports
3 participants