Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConsoleInteractionTest.py: Updated to reduce redundancy #6109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Dilshaad21
Copy link
Contributor

@Dilshaad21 Dilshaad21 commented Jan 10, 2020

Reduced redundancy by appending the arg list of the second function to the first one and
run it in a loop through all the arguments.

Closes #6056

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@Dilshaad21
Copy link
Contributor Author

@KVGarg PTAL

Copy link
Member

@akshatkarani akshatkarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good but improve the commit message (mention which functions you made changes to)

@Dilshaad21
Copy link
Contributor Author

@akshatkarani changes are done. PTAL

@akshatkarani
Copy link
Member

Minor typo in commit message listof

Reduced redundancy in test_ask_for_actions_and_apply
function by appending the arg list of the second
function to the first one and run it in a loop
through all the arguments.

Closes coala#6056
Copy link
Member

@akshatkarani akshatkarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;)

@abhishalya
Copy link
Member

Rebase please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

ConsoleInteractionTest.py: test_ask_for_actions_and_apply defined twice
3 participants