Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform moban synchronization after each push and each PR. #6124

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

chfw
Copy link

@chfw chfw commented May 18, 2020

No longer, a forgotten moban synchronzation cause issues.

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@chfw
Copy link
Author

chfw commented May 18, 2020

As you can see, the branch contained some updates that were performed by this github action.

Hence, looking at the number of developers in coala project, this github action would save a lot of developer time, not to worry about moban synchronization.

@abhishalya
Copy link
Member

@chfw Actually it's not that simple, coala has some commit checks which can cause the build to fail. Also, we don't support python 3.7 yet so the sync has some problems? I guess the changes are due to upstream templates. For some reason if you check the pinned version of moban here it doesn't give any new changes during sync. But upgrading it will give these changes.

@abhishalya
Copy link
Member

This will need another look as the current moban version does not add the python version 3.7 (which we don't support yet). I'm not exactly sure what the problem is or from which template this gets added.

@abhishalya abhishalya added the status/blocked The issue requires other referenced issues/PRs to be solved/merged before being worked on label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/blocked The issue requires other referenced issues/PRs to be solved/merged before being worked on
Development

Successfully merging this pull request may close these issues.

None yet

2 participants