Fix missing borders in Selects #15883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable mergeLongHand in cssnano. The official fix has already landed upstream but we unfortunately can't update cssnano without updating also CssMinimizerPlugin. An update of CssMinimizerPlugin will not work without webpack-5. Therefore let's keep the WA for now.
|
Sorry, I am bit out of context here. Can you please add link to "The official fix" and as well post before and after pictures? |
ah sorry - forgot to link the fix - we can update the commit message on merge cssnano/cssnano#1057 |
|
With the fix:
Before the fix: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable mergeLongHand in cssnano.
The official fix has already landed upstream but we unfortunately can't
update cssnano without updating also CssMinimizerPlugin.
An update of CssMinimizerPlugin will not work without webpack-5.
Therefore let's keep the WA for now.