Move from Webpack to Esbuild #18447

KKoukiou · 2023-03-03T16:56:54Z

Dependencies:

TODO:

pkg/build

martinpitt

Nice! I'm excited to see some progress here. Happy to help with the Debian copyright generation etc.

pkg/lib/cockpit-components-table.scss

pkg/lib/esbuild-eslint-plugin.js

packit.yaml

tools/esbuild-make

martinpitt · 2023-03-25T10:02:16Z

Yay, there's a new esbuild: https://github.com/evanw/esbuild/releases/tag/v0.17.13

I confirmed that wasm can now build this just fine, without the mega-commit 6a6d298 (saving the link here in case we need it again)

@KKoukiou : I squashed this again, as it needed a force-push anyway. Looks much cleaner now!

KKoukiou · 2023-03-25T10:40:05Z

all the rest pixel tests failures from This run don't look like regressions, rather are expected changes because of the breakpoints redefinition approach change.

martinpitt · 2023-03-26T23:05:01Z

I implemented a proper watch mode like in cockpit-project/cockpit-podman#1243 . Pushing it as a separate commit for review and history, but I'll squash it now, update pixel tests, and drop no-test. This will be the first push which has a chance to actually land.

The Python bridge stitches these files together with manifests.js. But esbuild does not auto-terminate the chunks with semicolons, so the call ended up as `cockpit.locale(...)cockpit.locale(...)`, which is invalid. Ensure to always terminate the cockpit.locale() call to fix that.

martinpitt

I went through this again with my reviewer goggles on, and found a few small cleanups. But before I push again, I want to see a fully green test set.

build.js

martinpitt · 2023-03-27T08:42:31Z

files.js

+    tests: [
+        "base1/test-base64",


Follow-up: Replace with a glob.

.. except that node.js does not have an API for globbing, meh..

build.js

We don't need the `$ESLINT`/`$STYLELINT` env variables any more to coordinate between build.js and webpack-config.js, as everything is in build.js now. Update HACKING.md accordingly. Implement our own watch mode due to the deficiencies of esbuild's [1]. This is similar to podman's [2], but with recursive watching. Because the approach for redefining breakpoints changed, update pixel tests for the spacing noise. Co-Authored-By: Martin Pitt <mpitt@redhat.com> Fixes cockpit-project#17629 [1] evanw/esbuild#1204 (comment) [2] cockpit-project/cockpit-podman#1243

…CSS anymore

Patternfly-react is in freeze right now, essentially till June when v5 is first released. This is a super hacky work around - but better than having UI regressions. This can be undone once patternfly with patternfly/patternfly-react#8864 is released.

martinpitt

I'm happy enough with this now, but of course I messed around with this heavily. Anything from your side still, @KKoukiou ?

@mvollmer , do you want to take a quick look?

KKoukiou · 2023-03-27T11:57:43Z

build.js

+        ".sh": "text",
+    },
+};
+
 const parser = (await import('argparse')).default.ArgumentParser();
 parser.add_argument('-c', '--config', { help: "Path to webpack.config.js", default: "webpack.config.js" });


Oops this option can now be dropped.

Let's wait for @mvollmer 's review, as this is otherwise green, and rather "expensive" (pixel tests, node_modules rebuild). I want to do a follow-up anyway to simplify tests in files.js, happy to clean it up then. Of course, when Marius finds other issues, we can fix this right away.

Fixed in #18565

KKoukiou added the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Mar 3, 2023

KKoukiou force-pushed the esbuild branch 4 times, most recently from 3c8148d to c0dccb9 Compare March 8, 2023 17:44

martinpitt reviewed Mar 14, 2023

View reviewed changes

pkg/build Outdated Show resolved Hide resolved

martinpitt reviewed Mar 14, 2023

View reviewed changes

pkg/lib/cockpit-components-table.scss Show resolved Hide resolved

pkg/lib/esbuild-eslint-plugin.js Outdated Show resolved Hide resolved

packit.yaml Outdated Show resolved Hide resolved

tools/esbuild-make Outdated Show resolved Hide resolved

martinpitt force-pushed the esbuild branch from c0dccb9 to eb4b599 Compare March 15, 2023 06:15

This comment was marked as resolved.

Sign in to view

martinpitt force-pushed the esbuild branch 2 times, most recently from 4b2f9cd to 9712875 Compare March 15, 2023 07:03

martinpitt added the .github-changes Set by a reviewer just before landing to acknowledge that a PR changes github workflows label Mar 15, 2023

github-actions bot removed the .github-changes Set by a reviewer just before landing to acknowledge that a PR changes github workflows label Mar 15, 2023

martinpitt temporarily deployed to cockpit-dist March 15, 2023 07:05 — with GitHub Actions Inactive

martinpitt force-pushed the esbuild branch from 9712875 to 801ac00 Compare March 15, 2023 07:59

martinpitt added the .github-changes Set by a reviewer just before landing to acknowledge that a PR changes github workflows label Mar 15, 2023

github-actions bot removed the .github-changes Set by a reviewer just before landing to acknowledge that a PR changes github workflows label Mar 15, 2023

martinpitt temporarily deployed to cockpit-dist March 15, 2023 08:00 — with GitHub Actions Inactive

martinpitt temporarily deployed to cockpit-dist March 15, 2023 10:00 — with GitHub Actions Inactive

martinpitt force-pushed the esbuild branch from 8b68ed0 to c3a42bd Compare March 15, 2023 12:41

martinpitt temporarily deployed to cockpit-dist March 15, 2023 12:42 — with GitHub Actions Inactive

martinpitt temporarily deployed to cockpit-dist March 15, 2023 13:08 — with GitHub Actions Inactive

martinpitt temporarily deployed to cockpit-dist March 15, 2023 13:51 — with GitHub Actions Inactive

martinpitt mentioned this pull request Mar 16, 2023

Various CSS/eslint/build system cleanups #18510

Closed

martinpitt temporarily deployed to cockpit-dist March 16, 2023 05:07 — with GitHub Actions Inactive

martinpitt force-pushed the esbuild branch from 737bdc8 to 0c8ad0e Compare March 16, 2023 05:44

martinpitt temporarily deployed to cockpit-dist March 16, 2023 05:45 — with GitHub Actions Inactive

martinpitt added the blocked label Mar 16, 2023

martinpitt mentioned this pull request Mar 16, 2023

build system cleanups for esbuild preparation #18512

Merged

KKoukiou temporarily deployed to cockpit-dist March 16, 2023 11:31 — with GitHub Actions Inactive

martinpitt force-pushed the esbuild branch 2 times, most recently from f62652e to 6a6d298 Compare March 24, 2023 07:42

martinpitt mentioned this pull request Mar 24, 2023

lib/cockpit-rsync-plugin: Fix return value on failures #18555

Merged

martinpitt force-pushed the esbuild branch from d44359c to 8b2b5d1 Compare March 25, 2023 10:01

This comment was marked as outdated.

Sign in to view

martinpitt force-pushed the esbuild branch 2 times, most recently from 053b612 to f92ea3c Compare March 26, 2023 23:03

martinpitt removed the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Mar 26, 2023

martinpitt force-pushed the esbuild branch from f92ea3c to 9b1cc4b Compare March 26, 2023 23:11

This comment was marked as resolved.

Sign in to view

martinpitt force-pushed the esbuild branch from 9b1cc4b to bce49f7 Compare March 27, 2023 08:31

martinpitt marked this pull request as ready for review March 27, 2023 08:32

martinpitt requested changes Mar 27, 2023

View reviewed changes

KKoukiou commented Mar 27, 2023

View reviewed changes

build.js Show resolved Hide resolved

KKoukiou added 3 commits March 27, 2023 11:45

pkg: No null loader is applied on page, toolbar and table components …

39c72cf

…CSS anymore

martinpitt force-pushed the esbuild branch from bce49f7 to 5a8707e Compare March 27, 2023 09:45

martinpitt approved these changes Mar 27, 2023

View reviewed changes

KKoukiou commented Mar 27, 2023

View reviewed changes

mvollmer approved these changes Mar 27, 2023

View reviewed changes

KKoukiou merged commit 584c9a3 into cockpit-project:main Mar 27, 2023

KKoukiou deleted the esbuild branch March 27, 2023 13:22

garrett mentioned this pull request Mar 27, 2023

CSS: Rework custom breakpoint CSS #17557

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move from Webpack to Esbuild #18447

Move from Webpack to Esbuild #18447

KKoukiou commented Mar 3, 2023 •

edited by martinpitt

martinpitt left a comment

This comment was marked as resolved.

martinpitt commented Mar 25, 2023

This comment was marked as outdated.

This comment was marked as outdated.

KKoukiou commented Mar 25, 2023

This comment was marked as outdated.

martinpitt commented Mar 26, 2023 •

edited

This comment was marked as resolved.

martinpitt left a comment

martinpitt Mar 27, 2023

martinpitt Mar 27, 2023

martinpitt left a comment

KKoukiou Mar 27, 2023

martinpitt Mar 27, 2023

martinpitt Mar 27, 2023

Move from Webpack to Esbuild #18447

Move from Webpack to Esbuild #18447

Conversation

KKoukiou commented Mar 3, 2023 • edited by martinpitt

martinpitt left a comment

Choose a reason for hiding this comment

This comment was marked as resolved.

martinpitt commented Mar 25, 2023

This comment was marked as outdated.

This comment was marked as outdated.

KKoukiou commented Mar 25, 2023

This comment was marked as outdated.

martinpitt commented Mar 26, 2023 • edited

This comment was marked as resolved.

martinpitt left a comment

Choose a reason for hiding this comment

martinpitt Mar 27, 2023

Choose a reason for hiding this comment

martinpitt Mar 27, 2023

Choose a reason for hiding this comment

martinpitt left a comment

Choose a reason for hiding this comment

KKoukiou Mar 27, 2023

Choose a reason for hiding this comment

martinpitt Mar 27, 2023

Choose a reason for hiding this comment

martinpitt Mar 27, 2023

Choose a reason for hiding this comment

KKoukiou commented Mar 3, 2023 •

edited by martinpitt

martinpitt commented Mar 26, 2023 •

edited