Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: don't fail tests on DNF5 #20467

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

jelly
Copy link
Member

@jelly jelly commented May 14, 2024

DNF 5 changed the systemd timers for dnf-automatic, this commit does not make Cockpit compatible with the new timers and configuration but unbreaks the current TF rawhide tests.

Related: #20260

@jelly jelly added the no-test For doc/workflow changes, or experiments which don't need a full CI run, label May 14, 2024
@jelly jelly requested a review from mvollmer May 14, 2024 15:34
@jelly
Copy link
Member Author

jelly commented May 14, 2024

This needs a new naughty for:

Wrote screenshot to TestAutoUpdates-testWithAvailableUpdates-fedora-41-10.88.0.1-22-FAIL.png
Wrote HTML dump to TestAutoUpdates-testWithAvailableUpdates-fedora-41-10.88.0.1-22-FAIL.html
Wrote JS log to TestAutoUpdates-testWithAvailableUpdates-fedora-41-10.88.0.1-22-FAIL.js.log
Journal extracted to TestAutoUpdates-testWithAvailableUpdates-fedora-41-10.88.0.1-22-FAIL.log.gz
> warning: transport closed: disconnected
Failed to reset failed state of unit packagekit.service: Unit packagekit.service not loaded.
Exiting due to channel error.
Exiting due to channel error.
Exiting due to channel error.
Exiting due to channel error.
Exiting due to channel error.
Traceback (most recent call last):
  File "/source/test/verify/check-packagekit", line 1581, in testWithAvailableUpdates
    b.wait_in_text("#autoupdates-settings", "Disabled")
  File "/source/test/common/testlib.py", line 704, in wait_in_text
    self.wait_js_cond("ph_in_text(%s,%s)" % (jsquote(selector), jsquote(text)),
  File "/source/test/common/testlib.py", line 642, in wait_js_cond
    self.raise_cdp_exception("timeout\nwait_js_cond", cond, result["exceptionDetails"], trailer)
  File "/source/test/common/testlib.py", line 332, in raise_cdp_exception
    raise Error("%s(%s): %s" % (func, arg, msg))
testlib.Error: timeout
wait_js_cond(ph_in_text("#autoupdates-settings","Disabled")): actual text: Automatic updatesNot set upEnable
warning: This error page has no error code in its security info
cdp: {'source': 'other', 'level': 'warning', 'text': 'Password fields present on an insecure (http://) page. This is a security risk that allows user login credentials to be stolen.', 'timestamp': 1715705449910, 'url': 'http://10.88.0.1:9090/updates', 'lineNumber': 0}
cdp: {'source': 'other', 'level': 'error', 'text': 'The resource from “http://10.88.0.1:9090/cockpit/@localhost/*/po.js” was blocked due to MIME type (“text/html”) mismatch (X-Content-Type-Options: nosniff).', 'timestamp': 1715705450856, 'url': 'http://10.88.0.1:9090/updates', 'lineNumber': 0}
cdp: {'source': 'other', 'level': 'error', 'text': 'The resource from “http://10.88.0.1:9090/cockpit/@localhost/*/po.manifest.js” was blocked due to MIME type (“text/html”) mismatch (X-Content-Type-Options: nosniff).', 'timestamp': 1715705450905, 'url': 'http://10.88.0.1:9090/updates', 'lineNumber': 0}
cdp: {'source': 'other', 'level': 'error', 'text': 'The resource from “http://10.88.0.1:9090/cockpit/@localhost/*/po.manifest.js” was blocked due to MIME type (“text/html”) mismatch (X-Content-Type-Options: nosniff).', 'timestamp': 1715705451019, 'url': 'http://10.88.0.1:9090/updates', 'lineNumber': 0}
cdp: {'source': 'other', 'level': 'warning', 'text': 'Loading failed for the <script> with source “http://10.88.0.1:9090/cockpit/@localhost/*/po.manifest.js”.', 'timestamp': 1715705451022, 'url': 'http://10.88.0.1:9090/updates', 'lineNumber': 13}
cdp: {'source': 'other', 'level': 'error', 'text': 'The resource from “http://10.88.0.1:9090/cockpit/@localhost/*/po.js” was blocked due to MIME type (“text/html”) mismatch (X-Content-Type-Options: nosniff).', 'timestamp': 1715705451033, 'url': 'http://10.88.0.1:9090/updates', 'lineNumber': 0}
cdp: {'source': 'other', 'level': 'warning', 'text': 'Loading failed for the <script> with source “http://10.88.0.1:9090/cockpit/@localhost/*/po.js”.', 'timestamp': 1715705451040, 'url': 'http://10.88.0.1:9090/updates', 'lineNumber': 14}

# Result testWithAvailableUpdates (__main__.TestAutoUpdates.testWithAvailableUpdates) failed
# 1 TEST FAILED [29s on 59fd760ebae0]
not ok 1 test/verify/check-packagekit TestAutoUpdates.testWithAvailableUpdates [ND@-1] # RETRY 1 (be robust against unstable tests)

We aren't compatible yet with the new way.

@jelly
Copy link
Member Author

jelly commented May 14, 2024

Or alternative skipTodo!

mvollmer
mvollmer previously approved these changes May 15, 2024
Copy link
Member

@mvollmer mvollmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

jelly added 2 commits May 15, 2024 16:36
DNF 5 changed the systemd timers for dnf-automatic, this commit does not
make Cockpit compatible with the new timers and configuration but
unbreaks the current TF rawhide tests.

Related: cockpit-project#20260
Cockpit is not yet compatible with the new DNF 5 automatic plugin.

Related: cockpit-project#20260
@jelly jelly removed the no-test For doc/workflow changes, or experiments which don't need a full CI run, label May 15, 2024
@jelly jelly requested a review from mvollmer May 15, 2024 14:37
@jelly
Copy link
Member Author

jelly commented May 15, 2024

# Result testUserPasswords (__main__.TestAccounts.testUserPasswords) failed
# 1 TEST FAILED [46s on 30ea1c694ce4]
not ok 54 test/verify/check-users TestAccounts.testUserPasswords [ND@-1] # RETRY 1 (be robust against unstable tests)

Rawhide fails on this, we have a naughty open for it.

Copy link
Member

@mvollmer mvollmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's green, yay!

@mvollmer mvollmer merged commit 0f4ceb5 into cockpit-project:main May 16, 2024
79 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants