Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: sqlstats: generate PCT_RUNTIME sort when requested #123903

Merged
merged 1 commit into from May 14, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented May 9, 2024

Backport 1/1 commits from #123846 on behalf of @dhartunian.

/cc @cockroachdb/release


Previously, when a request was made to the combined stats endpoint on CRDB with a PCT_RUNTIME sort, we'd default to a svcLatency sort instead because of a missing switch case.

This change fills that gap and adds some datadriven tests to inspect the resulting WHERE clauses.

Fixes: #123841
Epic: CRDB-37544

Release note (ui change): Viewing SQL Activity sorted by % of Runtime now correctly sorts entries by the runtime amount.


Release justification: low-risk, high-impact bugfix for sql stats

Previously, when a request was made to the combined stats endpoint on
CRDB with a `PCT_RUNTIME` sort, we'd default to a `svcLatency` sort
instead because of a missing switch case.

This change fills that gap and adds some datadriven tests to inspect
the resulting `WHERE` clauses.

Fixes: #123841
Epic: CRDB-37544

Release note (ui change): Viewing SQL Activity sorted by `% of
Runtime` now correctly sorts entries by the runtime amount.
@blathers-crl blathers-crl bot requested a review from a team as a code owner May 9, 2024 18:42
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.1-123846 branch from 530d21e to 143cb36 Compare May 9, 2024 18:42
@blathers-crl blathers-crl bot requested review from abarganier and removed request for a team May 9, 2024 18:42
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels May 9, 2024
Copy link
Author

blathers-crl bot commented May 9, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot requested review from dhartunian and xinhaoz May 9, 2024 18:42
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label May 9, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@dhartunian dhartunian requested review from rafiss and removed request for dhartunian May 9, 2024 20:44
@dhartunian dhartunian merged commit 5db5054 into release-24.1 May 14, 2024
19 of 20 checks passed
@dhartunian dhartunian deleted the blathers/backport-release-24.1-123846 branch May 14, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants