release-24.1: skip,metamorphic: break dependency on metamorphic
from skip
#123915
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #123819 on behalf of @rickystewart.
/cc @cockroachdb/release
It would be nice to have a way to clearly determine whether any one package uses metamorphic constants, however that's difficult since
pkg/testutils/skip
(which many test packages use) depends onmetamorphic
. This PR breaks that dependency, so we can query the dependency graph to themetamorphic
dependency to determine exactly which packages use metamorphic constants. Instead, we haveskip
depend on a new packagemetamorphicutil
which is very restricted in use.metamorphic
can also do setup in itsinit()
function that we know for sure is not needed unless metamorphic constants are specifically requested.Epic: none
Release note: None
Release justification: Non-production code changes