New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: upgrade antd
package to v5 in cluster-ui
#123973
base: master
Are you sure you want to change the base?
Conversation
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. Before a member of our team reviews your PR, I have some potential action items for you:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. Thank you for updating your pull request. Before a member of our team reviews your PR, I have some potential action items for you:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
UX concerns:
|
- upgrade and version to 5.6.1 in package.json. It is the same version of antd that's used in CC Console. - remove babel configs related to antd (deprecated) - remove overridden antd global styles - all of these changes are done according to migration instruction https://ant.design/docs/react/migration-v5 Release note: None
Those changes produced by command: `pnpm --package=@ant-design/codemod-v5 dlx antd5-codemod src` which applies automatic fixes during Antd version upgrade to 5v. Release note: None
…uster-ui This change resolves issues that couldn't be fixed automatically during `antd` version upgrade and require changes to resolve breaking changes. Following components were mostly affected: - `<Icon/>` - `<DatePicker/>` - `<Select/>` In addition, proper types were provided due to resolve compilation errors.
This change adds a copy of antd theme from CC Console to rely on the same styles. It will help to adjust components to the same styles as in CC Console during extraction components. Release note: None
- default button type with borders was overridden by global styles so former were removed; - time and date selectors size is set to 'large' to keep the same size of component as before; Release note: None
672e213
to
5aaf037
Compare
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. Thank you for updating your pull request. Before a member of our team reviews your PR, I have some potential action items for you:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This change adjusts styling of <Search /> component after antd version upgrade that affected styles. - cleaned up some style that override `antd` styles as they don't make any sense; - removed `<Form />` component as a wrapper that was responsible to handle event when user presses Enter button. Now it is possible to handle within `<Input />` component. Release note: None
5aaf037
to
6f964b0
Compare
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. Thank you for updating your pull request. Before a member of our team reviews your PR, I have some potential action items for you:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
ActivateStatementDiagnosticsModal component is based on pure Antd components and has been dramatically affected after upgrade of Antd version to 5.x. The main issue that new components are based on flexbox styles and it caused many changes in layout and how components structured. So this change introduced following changes: - avoid using `<div>` elements for structuring layout, instead use <Space> and <Grid> components. - Remove unused styles and rely on antdTheme instead as much as possible. There is some styles defined which cannot be defined with theme. Release note: None
This patch doesn't affect how `JobsProfileView` component looks, instead it fixes some broken styles after `antd` package has been upgraded. Also, `Space` components are used for better layout structuring instead of `<Row>` and `<Col>` components. Release note: None
6f964b0
to
3737180
Compare
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. Thank you for updating your pull request. Before a member of our team reviews your PR, I have some potential action items for you:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This change upgrades
antd
package (in cluster-ui) up to 5.x version to matchthe version in CC Console and make it easier to extract components.
It is preferable to review those changes per commit:
pnpm --package=@ant-design/codemod-v5 dlx antd5-codemod src
antd
version upgrade.Note, those changes doesn't fix broken styles of components and it affects
how some components look in Db Console.
Resolves: https://cockroachlabs.atlassian.net/browse/CC-28016
dev ui mirror-deps