Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

githubpost: assign backupccl test failures to disaster-recovery #123983

Merged
merged 1 commit into from May 13, 2024
Merged

githubpost: assign backupccl test failures to disaster-recovery #123983

merged 1 commit into from May 13, 2024

Conversation

renatolabs
Copy link
Collaborator

Temporary workaround for backupccl failures, by far the most common occurrence of #107885.

Informs: #107885

Release note: None

@renatolabs
githubpost: assign backupccl test failures to disaster-recovery
feab208 
Temporary workaround for `backupccl` failures, by far the most common
occurrence of cockroachdb#107885.

Informs: cockroachdb#107885

Release note: None
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented May 11, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@renatolabs renatolabs requested review from a team, nameisbhaskar and vidit-bhat and removed request for a team May 13, 2024 03:28
@renatolabs renatolabs marked this pull request as ready for review May 13, 2024 03:29
@renatolabs renatolabs requested a review from a team as a code owner May 13, 2024 03:29
@renatolabs
Copy link
Collaborator Author

TFTR!

bors r=herkolategan

@renatolabs renatolabs added backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1. labels May 13, 2024
@craig
Copy link
Contributor

craig bot commented May 13, 2024

Build succeeded:

@craig craig bot merged commit 2f739e8 into cockroachdb:master May 13, 2024
22 checks passed
This was referenced May 13, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herkolategan herkolategan herkolategan approved these changes

@nameisbhaskar nameisbhaskar Awaiting requested review from nameisbhaskar nameisbhaskar was automatically assigned from cockroachdb/test-eng

@vidit-bhat vidit-bhat Awaiting requested review from vidit-bhat vidit-bhat was automatically assigned from cockroachdb/test-eng

Assignees
No one assigned
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@renatolabs @cockroach-teamcity @herkolategan