Merge pull request #8 from bugeats/fix-standalone

Fix standalone attribute to render valid XML
cocool97 · Nov 5, 2022 · 11c88f7 · 11c88f7
2 parents 7dd697a + 643074c
commit 11c88f7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/xml.rs b/src/xml.rs
@@ -67,10 +67,9 @@ impl XML {
     ///
     /// Consumes the XML object.
     pub fn generate<W: Write>(self, mut writer: W) -> Result<()> {
-        let standalone_attribute = if let Some(standalone) = self.standalone {
-            format!(r#" standalone="{}""#, standalone.to_string())
-        } else {
-            String::default()
+        let standalone_attribute = match self.standalone {
+            Some(_) => r#" standalone="yes""#.to_string(),
+            None => String::default(),
         };
 
         writeln!(

diff --git a/tests/tests.rs b/tests/tests.rs
@@ -209,7 +209,7 @@ fn test_complex_sorted_element_xml() {
     let mut writer: Vec<u8> = Vec::new();
     xml.generate(&mut writer).unwrap();
 
-    let expected = "<?xml version=\"1.1\" encoding=\"UTF-8\" standalone=\"true\"?>
+    let expected = "<?xml version=\"1.1\" encoding=\"UTF-8\" standalone=\"yes\"?>
 <house rooms=\"2\">
 \t<room size=\"27\" city=\"Paris\" number=\"1\">This is room number 1</room>
 \t<room city=\"LA\" number=\"2\" size=\"54\">This is room number 2</room>