-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lots of type issues in Tween system #16948
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
bb31f0a
Add generic for action types.
dumganhar c1f7798
Action class should not be a template.
dumganhar d7cc73e
Update
dumganhar 09ea1cf
Revert
dumganhar 0bf9b6a
Revert again.
dumganhar f170af4
More type fixes.
dumganhar 6d8b592
Remove unused function _searchElementByTarget in action-manager.ts an…
dumganhar 9dbef39
Remove two unused functions - 'easing' and '_computeEaseTime' in acti…
dumganhar 142f869
Use abstract keyword for abstract classes in actions.
dumganhar 74fc3f3
More specific type for action factory functions.
dumganhar c48c839
Tween.call supports to pass this object and custom data.
dumganhar 8435739
Revert initWithAction
dumganhar a06d144
Remove more eslint comments.
dumganhar 773291e
Rename
dumganhar 81be9f6
More ? to if
dumganhar 4c51ce6
Remove unused T for removeAction in action-manager.ts
dumganhar 5320dd3
Add insertAction private method for inserting a action to current tween.
dumganhar 3138562
format code for torus.ts
dumganhar 1410d00
Tween.show/hide/removeSelf/destroySelf return unknown type if T is no…
dumganhar 046cd0f
Update comment
dumganhar 4cdfb19
opts.!relative -> opts.relative.
dumganhar 7ea568c
Set target to null in Action.stop
dumganhar 43dffb9
Tween<T> ---> Tween<T extends object = any>
dumganhar d25cf8f
Update ci
dumganhar File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the error: