Unbreak GHDL nightly CI #2947
Merged
Unbreak GHDL nightly CI #2947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GHDL nightly builds for Ubuntu 20.04 are not provided for mcode any more, but only for llvm. Let's switch to that.
|
GHDL nightly is fixed by this PR, but we see another error with Python 3.11. I'm not yet sure where the failure really comes from, but we at least have to look into |
Codecov Report
@@ Coverage Diff @@
## master #2947 +/- ##
==========================================
+ Coverage 59.90% 60.34% +0.44%
==========================================
Files 28 28
Lines 5848 5848
Branches 1521 1392 -129
==========================================
+ Hits 3503 3529 +26
+ Misses 2064 2035 -29
- Partials 281 284 +3
Continue to review full report at Codecov.
|
|
3.11 failure actually due to an issue with coverage package https://github.com/cocotb/cocotb/runs/6147105555?check_suite_focus=true#step:25:976. |
Ah, good catch. I missed that one when scrolling through. I filed #2949, as it's unrelated to what this PR is trying to accomplish. |
|
And I filed #2950 for the ResourceWarning. |
imphil
force-pushed
the
ghdl-ci-fix-nightly-llvm
branch
from
bd88815
to
3e40f0f
Compare
ktbarrett
approved these changes
Apr 24, 2022
|
Is there an issue in GHDL or some announcement from them as to why they aren't providing the mcode backend in the nightly builds anymore? |
I haven't seen anything. But I'm slightly annoyed by the repeated breakage of the GHDL nightly regression anyways, maybe it's time to remove it -- there's little point in testing unstable code in a PR against unstable simulators. |
imphil
added a commit
to imphil/cocotb
that referenced
this pull request
May 17, 2022
GHDL Nightly build artifacts are not reliably available and have caused frequent build failures. Furthermore, testing an unstable (to-be-tested) version of cocotb against a unknown version of a simulator isn't a good match for a CI environment, where we want to see if the changeset broke something, not if a simulator update broke something. See also * cocotb#2947 * cocotb#2926 * Right now, GHDL nightly is failing because the GHDL CI failed to upload an Ubuntu 20.04 binary (https://github.com/ghdl/ghdl/runs/6475779323?check_suite_focus=true).
imphil
added a commit
to imphil/cocotb
that referenced
this pull request
May 17, 2022
GHDL Nightly build artifacts are not reliably available and have caused frequent build failures. Furthermore, testing an unstable (to-be-tested) version of cocotb against a unknown version of a simulator isn't a good match for a CI environment, where we want to see if the changeset broke something, not if a simulator update broke something. See also * cocotb#2947 * cocotb#2926 * Right now, GHDL nightly is failing because the GHDL CI failed to upload an Ubuntu 20.04 binary (https://github.com/ghdl/ghdl/runs/6475779323?check_suite_focus=true).
imphil
added a commit
to imphil/cocotb
that referenced
this pull request
May 18, 2022
GHDL Nightly build artifacts are not reliably available and have caused frequent build failures. Furthermore, testing an unstable (to-be-tested) version of cocotb against a unknown version of a simulator isn't a good match for a CI environment, where we want to see if the changeset broke something, not if a simulator update broke something. See also * cocotb#2947 * cocotb#2926 * Right now, GHDL nightly is failing because the GHDL CI failed to upload an Ubuntu 20.04 binary (https://github.com/ghdl/ghdl/runs/6475779323?check_suite_focus=true).
imphil
added a commit
to imphil/cocotb
that referenced
this pull request
May 18, 2022
GHDL Nightly build artifacts are not reliably available and have caused frequent build failures. Furthermore, testing an unstable (to-be-tested) version of cocotb against a unknown version of a simulator isn't a good match for a CI environment, where we want to see if the changeset broke something, not if a simulator update broke something. See also * cocotb#2947 * cocotb#2926 * Right now, GHDL nightly is failing because the GHDL CI failed to upload an Ubuntu 20.04 binary (https://github.com/ghdl/ghdl/runs/6475779323?check_suite_focus=true).
imphil
added a commit
to imphil/cocotb
that referenced
this pull request
May 18, 2022
GHDL Nightly build artifacts are not reliably available and have caused frequent build failures. Furthermore, testing an unstable (to-be-tested) version of cocotb against a unknown version of a simulator isn't a good match for a CI environment, where we want to see if the changeset broke something, not if a simulator update broke something. See also * cocotb#2947 * cocotb#2926 * Right now, GHDL nightly is failing because the GHDL CI failed to upload an Ubuntu 20.04 binary (https://github.com/ghdl/ghdl/runs/6475779323?check_suite_focus=true).
imphil
added a commit
to imphil/cocotb
that referenced
this pull request
May 18, 2022
Split the GHDL testing into two buckets: - Use a stable release version of GHDL for CI (pull request) testing. - Test the latest master of GHDL in the extended tests. GHDL 2.0 is the first version that works with cocotb. Use this version for CI testing, and document this fact. For experimental testing, use the GHDL master from Git and compile it ourselves. The GHDL nightly build artifacts (and the associated GitHub actions) have been unreliable for us in the past, and provide no real value. See also * cocotb#2947 * cocotb#2926 * Right now, GHDL nightly is failing because the GHDL CI failed to upload an Ubuntu 20.04 binary (https://github.com/ghdl/ghdl/runs/6475779323?check_suite_focus=true).
imphil
added a commit
to imphil/cocotb
that referenced
this pull request
May 18, 2022
Split the GHDL testing into two buckets: - Use a stable release version of GHDL for CI (pull request) testing. - Test the latest master of GHDL in the extended tests. GHDL 2.0 is the first version that works with cocotb. Use this version for CI testing, and document this fact. For experimental testing, use the GHDL master from Git and compile it ourselves. The GHDL nightly build artifacts (and the associated GitHub actions) have been unreliable for us in the past, and provide no real value. See also * cocotb#2947 * cocotb#2926 * Right now, GHDL nightly is failing because the GHDL CI failed to upload an Ubuntu 20.04 binary (https://github.com/ghdl/ghdl/runs/6475779323?check_suite_focus=true).
imphil
added a commit
to imphil/cocotb
that referenced
this pull request
May 22, 2022
Split the GHDL testing into two buckets: - Use a stable release version of GHDL for CI (pull request) testing. - Test the latest master of GHDL in the extended tests. GHDL 2.0 is the first released version that passes our test suite (as of today). It also happens to be the latest released version. Use this version for CI testing, and document the fact that earlier versions don't pass our test suite (earlier version might still work for certain scenarios). For experimental testing, use the GHDL master from Git and compile it ourselves. The GHDL nightly build artifacts (and the associated GitHub actions) have been unreliable for us in the past, and provide no real value. See also * cocotb#2947 * cocotb#2926 * Right now, GHDL nightly is failing because the GHDL CI failed to upload an Ubuntu 20.04 binary (https://github.com/ghdl/ghdl/runs/6475779323?check_suite_focus=true).
imphil
added a commit
that referenced
this pull request
May 23, 2022
Split the GHDL testing into two buckets: - Use a stable release version of GHDL for CI (pull request) testing. - Test the latest master of GHDL in the extended tests. GHDL 2.0 is the first released version that passes our test suite (as of today). It also happens to be the latest released version. Use this version for CI testing, and document the fact that earlier versions don't pass our test suite (earlier version might still work for certain scenarios). For experimental testing, use the GHDL master from Git and compile it ourselves. The GHDL nightly build artifacts (and the associated GitHub actions) have been unreliable for us in the past, and provide no real value. See also * #2947 * #2926 * Right now, GHDL nightly is failing because the GHDL CI failed to upload an Ubuntu 20.04 binary (https://github.com/ghdl/ghdl/runs/6475779323?check_suite_focus=true).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GHDL nightly builds for Ubuntu 20.04 are not provided for mcode any
more, but only for llvm. Let's switch to that.