Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACI compute-worker feature #8

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

igormusinov
Copy link

@igormusinov igormusinov commented Jul 31, 2019

@igormusinov
Copy link
Author

Hi @ckcollab ! I would be happy to commit to this project. Here is our team's instance of the codalab https://codalab.coresearch.club/ . Could you please guide me what I should do first to make a commit ?

@ckcollab
Copy link
Contributor

This seems like it should become a fork instead of get merged upstream? We don't use this on Codalab production.

@ckcollab
Copy link
Contributor

Just seeing your comment now, I think this is fine stuff but a different approach than we use. As separate repos seems to make sense. I could add an "alternative workers" section? Version 2 of Codalab is here with completely different workers:
https://github.com/codalab/competitions-v2/tree/develop/docker/compute_worker

@igormusinov
Copy link
Author

igormusinov commented Feb 15, 2020

I think this is fine stuff but a different approach than we use

something like that , but at the same time there is some fixes with old code (alternative queue bug, logs). And I didn't change a lot of code for local worker

"I could add an "alternative workers" section"

it would be cool

Version 2 of Codalab is here with completely different workers:
https://github.com/codalab/competitions-v2/tree/develop/docker/compute_worker

cool , but is compute_worker-v2 backward compatible with v1 ?

@ckcollab
Copy link
Contributor

I could add an "alternative workers" section

it would be cool

Added!

cool , but is compute_worker-v2 backward compatible with v1 ?

The worker expects to be used quite differently, but v1 competitions should port over to v2 fine. I'm sure there are still many small discrepancies, v2 is still very early in actual usage, but we've made quite a few competitions work properly.

Main benefits of the new worker: API back to Codalab during runs + websockets to talk back to Codalab to give real time stdout and whatever features we can dream up. I.e. realtime error rate updates, status updates (submitted, running, finished, etc.) so you don't have to refresh the page, sending back chart data to the frontend, python 3, etc.

Igor and others added 9 commits February 22, 2020 00:27
1. add file with list of workers with stage type
2. docker deploy fixes (with list + stage configs)
steps variable for "Mount to saved weights for user visibility" task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants