Music: use sounds panel revision #58655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breville
changed the title
sanchitmalhotra126
approved these changes
May 16, 2024
| // Capture whether the initially-selected sound is the default sound, in which | ||
| // case we will do a smooth scroll into view, rather than scroll directly | ||
| // to the current sound. | ||
| const isDefaultSoundSelected = useRef( |
There was a problem hiding this comment.
To check my understanding: we're using useRef so that the below useEffect only runs on initial render, and not whenever currentValue changes, right? If so, mind updating the comment to capture that?
There was a problem hiding this comment.
Yes, that's right. Comment updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the revised sounds panel introduced in #58275 becomes the default.
Two UI issues have been fixed:
The
ScrollIntoViewcomponent has been renamedEaseIntoViewto alleviate confusion with the browser's existingscrollIntoViewfunction.A DCDO flag of
"music-lab-use-sounds-panel-1"can be set totrueor thesounds-panel-2=falseURL parameter can continue to be used to switch back to the legacy sounds panel.