-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign up translation strings #58661
Sign up translation strings #58661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a typo and have a question, but otherwise looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woah a new file! Are there any additional steps we need to do to make sure this file is synced to Crowdin and that we can access the strings during development?
I'm still waiting to hear a final confirmation on this thread! |
It looks like we theoretically have a process for this in the new i18n documentation, but it references a file that I can't find. I commented and am waiting for a reply there. |
I added a new signup_locale.js file at Mario's suggestion! The latest commit should make imports easily accessible. |
Yay! And it looks like we automatically pull in any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the sync in & up and the new file is picked up.
Added the new header string to the spreadsheet! |
This PR adds all new strings for the sign up flow edits coming soon. When I merge this pr, I will also add a new line to this spreadsheet for the new casing of Create account.
After consulting with the i18n team, I decided to throw these in their own file instead of reusing /common.
Here is the figma to all these new strings!!
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: