Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign up translation strings #58661

Merged
merged 5 commits into from
May 21, 2024
Merged

Conversation

hannahbergam
Copy link
Contributor

@hannahbergam hannahbergam commented May 15, 2024

This PR adds all new strings for the sign up flow edits coming soon. When I merge this pr, I will also add a new line to this spreadsheet for the new casing of Create account.

After consulting with the i18n team, I decided to throw these in their own file instead of reusing /common.

Here is the figma to all these new strings!!

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@hannahbergam hannahbergam marked this pull request as ready for review May 16, 2024 22:15
@hannahbergam hannahbergam requested a review from a team as a code owner May 16, 2024 22:15
@hannahbergam hannahbergam requested a review from a team May 17, 2024 21:27
Copy link
Contributor

@kelbyhawn kelbyhawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a typo and have a question, but otherwise looks great!

apps/i18n/signup/en_us.json Outdated Show resolved Hide resolved
apps/i18n/signup/en_us.json Outdated Show resolved Hide resolved
Copy link
Contributor

@bethanyaconnor bethanyaconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woah a new file! Are there any additional steps we need to do to make sure this file is synced to Crowdin and that we can access the strings during development?

@hannahbergam
Copy link
Contributor Author

woah a new file! Are there any additional steps we need to do to make sure this file is synced to Crowdin and that we can access the strings during development?

I'm still waiting to hear a final confirmation on this thread!

@hannahbergam
Copy link
Contributor Author

woah a new file! Are there any additional steps we need to do to make sure this file is synced to Crowdin and that we can access the strings during development?

I'm still waiting to hear a final confirmation on this thread!

It looks like we theoretically have a process for this in the new i18n documentation, but it references a file that I can't find. I commented and am waiting for a reply there.

@hannahbergam
Copy link
Contributor Author

woah a new file! Are there any additional steps we need to do to make sure this file is synced to Crowdin and that we can access the strings during development?

I added a new signup_locale.js file at Mario's suggestion! The latest commit should make imports easily accessible.

@bethanyaconnor
Copy link
Contributor

Yay! And it looks like we automatically pull in any en_us.json file for translation, so we're set there 🎉

Copy link
Contributor

@bethanyaconnor bethanyaconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@mgc1194 mgc1194 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the sync in & up and the new file is picked up.

@hannahbergam
Copy link
Contributor Author

Added the new header string to the spreadsheet!

@hannahbergam hannahbergam merged commit 537d90b into staging May 21, 2024
2 checks passed
@hannahbergam hannahbergam deleted the hbergam/signup-translations-prep branch May 21, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants