Applab: fix screen import ID conflict between screen and element

[bencodeorg]

Applab has a feature that allows you to import "screens" from other projects:

When using this feature, we have code that:

• handles a conflict between two projects with screens with the same IDs, and
• handles conflicts between two projects with individual elements (eg, buttons) with the same IDs.

A recent curriculum update (more detail here) exposed the fact that we don't handle two other sets of potential conflicts:

Conflict between...	Current project	Imported screen	Result
	screen ID	element ID	error, dialog hangs
	element ID	screen ID	Import "succeeds", silently wipes element with name conflict from existing project

The change here is to treat these conflicts the same way that we treat conflicts between individual elements (eg, a button in the existing project matches a button in the screen to import). I include a slight rewording of the error message to support these cases.

Updated experience
Conflicts between screen IDs and element IDs appear in list of IDs preventing import. In this case, the project trying to do the import has a button with the ID screen1, and the screen to import has the ID screen1

Links

• jira: https://codedotorg.atlassian.net/browse/LABS-691
• slack discussion

Testing story

I tested manually:

• Each of the "cross-type" collision types (ie, screen ID-element ID collisions) blocks import gracefully per the screenshot above.
• Screen ID-screen ID collision still offers the user the opportunity to overwrite their existing screen.
• Element ID-element ID collision continues to blocks import of a screen.
• Screen imports without any of these collisions succeed.

[breville]

Excellent write-up and clarity around the entire test matrix.

[fisher-alice]

Nice and +1 on well-written description! Just left a couple nits. Thanks!

[fisher-alice]

This is not your change, but wondering if the wording could be updated.
'Fix the IDs in either project so that they aren't duplicated between the two projects before trying to import.'
We already ensure that element/screen IDs are not duplicated across screens within the same project.
@dancodedotorg - lmk what you think. Thanks!

[bencodeorg]

Took me a sec to follow so just to clarify, I think the specific proposed diff is:

"Fix the IDs in either project so they aren't duplicated across different screens between the two projects before trying to import"

This change makes sense to me though, updated! I think we can make an executive decision here unless Dan objects.

[dancodedotorg]

I trust y'all - don't wait up on me

[sanchitmalhotra126]

Nice sleuthing!