Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Music: fix zero key #58672

Merged
merged 2 commits into from
May 17, 2024
Merged

Music: fix zero key #58672

merged 2 commits into from
May 17, 2024

Conversation

breville
Copy link
Member

Fixes an issue in which switching to a pack with a key of 0 was not applying that key.

@breville breville requested review from moneppo and a team May 16, 2024 03:06
thomasoniii
thomasoniii requested changes May 16, 2024
View reviewed changes
Copy link
Contributor

@thomasoniii thomasoniii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a note on the PR - use the nullish coalescing operator instead of a ternary.

@breville breville requested a review from thomasoniii May 16, 2024 18:08
sanchitmalhotra126
sanchitmalhotra126 approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@sanchitmalhotra126 sanchitmalhotra126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

thomasoniii
thomasoniii approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@thomasoniii thomasoniii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@breville breville merged commit 23d09af into staging May 17, 2024
2 checks passed
@breville breville deleted the music-fix-zero-key branch May 17, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasoniii thomasoniii thomasoniii approved these changes

@sanchitmalhotra126 sanchitmalhotra126 sanchitmalhotra126 approved these changes

@moneppo moneppo Awaiting requested review from moneppo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@breville @thomasoniii @sanchitmalhotra126