Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add age to CPA amplitude events in state modal #58679

Merged
merged 2 commits into from
May 17, 2024

Conversation

juanmanzojr
Copy link
Contributor

@juanmanzojr juanmanzojr commented May 16, 2024

Adds the Student Age to all amplitude events within the CPA State modal.
Also includes a small edit to the submit button:
For English users change the button from "Continue" to "Submit"
Screenshot 2024-05-16 at 1 33 27 AM

Amplitude Event Console Logs

Screenshot 2024-05-16 at 1 35 13 AM Screenshot 2024-05-16 at 1 31 03 AM

If Age was null before, updates the value if found when submitted

Screenshot 2024-05-16 at 1 33 37 AM

Links

Testing story

Local amplitude console logs

@juanmanzojr juanmanzojr requested a review from a team May 16, 2024 16:53
Copy link
Contributor

@wilkie wilkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

If there are any tests for this event, be sure to add coverage of this age parameter. But it seems like we don't really write tests for these layout scripts? Let me know if I'm wrong here.

…html.haml

Co-authored-by: Artem Vavilov <artem.vavilov.7@gmail.com>
@juanmanzojr juanmanzojr merged commit 305f566 into staging May 17, 2024
2 checks passed
@juanmanzojr juanmanzojr deleted the add-age-to-cpa-amplitude branch May 17, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants