Associate Cloudfront Distributions to WAF WEB ACL #58682
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -227,7 +227,8 @@ def self.distribution_config(app, origin, aliases, ssl_cert = nil) | |||
| CloudFrontDefaultCertificate: true, | |||
| MinimumProtocolVersion: 'TLSv1' # accepts SSLv3, TLSv1 | |||
| }, | |||
| HttpVersion: 'http2' | |||
| HttpVersion: 'http2', | |||
| WebACLId: {'Fn::Sub': 'arn:aws:wafv2:${AWS::Region}:${AWS::AccountId}:global/webacl/code-dot-org/a79a67de-dabf-4555-a8dc-98c3a20b562f'} | |||
There was a problem hiding this comment.
Will this apply to adhocs? E.g. will it put the bugcrowd adhoc behind the prod WAF?
There was a problem hiding this comment.
It would. There isn't a different ACL existing today that we would want to use for adhocs, so the question is whether they should be added to the ACL or have no ACL.
cat5inthecradle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associate our cloudfront distributions to our WAF ACL via code. Without this here, any other changes to this DistributionConfig will disassociate the distribution from our WAF ACL.
Links
Testing story
IN PROGRESS - generating and linting templates for staging, test and production.
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: