Fix: Readd toolTipContainer styles to sections-refresh #58696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebeastlake
requested review from
stephenliang,
bethanyaconnor,
kakiha11,
a team and
lfryemason
and removed request for
a team
bethanyaconnor
approved these changes
May 17, 2024
lfryemason
approved these changes
May 17, 2024
stephenliang
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When PR https://github.com/code-dot-org/code-dot-org/pull/58038/files was merged, the sections-refresh module was imported into the
SectionAccessToggle.tsxand had unintended consequences in the teacher dashboard because it has some very broad CSS selectors.The Slack thread on the original issue was: https://codedotorg.slack.com/archives/C045UAX4WKH/p1715806578458379?thread_ts=1715803641.843369&cid=C045UAX4WKH
When I put up the revert of the revert, I moved the CSS for the tooltips into a dedicated
access-controls.module.scss, which kept the overly scopedsections-refreshrules from applying across the teacher dashboard: https://github.com/code-dot-org/code-dot-org/pull/58659/files/a681e72105862d5b78068298fe4bbd66267b5f46..67852a06652225a93a2c4e5e47a2bb54ca788335BUT, I made a mistake by removing the toolTipContainer from the
sections-refreshcontainer https://github.com/code-dot-org/code-dot-org/pull/58659/files/a681e72105862d5b78068298fe4bbd66267b5f46..67852a06652225a93a2c4e5e47a2bb54ca788335#diff-e26532ee34fdf045c225c00b1fd13d15158929aba3b198ee9711b5e1f994806dL182 because I assumed it had been added by @kakiha11 in the original PR.It is necessary for the other Advanced Settings tooltips, and wasn't caught by existing UI tests.
Links
Testing story
I confirmed locally that the appearance and CSS being applied here now match what they were before yesterday night.
Deployment strategy
Follow-up work
Added a task to add UI tests for Advanced Settings section toggles: https://codedotorg.atlassian.net/browse/TEACH-1113
Privacy
Security
Caching
PR Checklist: